834447 - IonMonkey: Make Ion entry use AbstractFramePtr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

This is needed for doing baseline/ion OSR.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Patch.

AbstractFramePtr is an abstraction around a pointer to a vm StackFrame, so we can pass in a BaselineFrame to various places that previously only accepted a StackFrame ptr.

This adjusts Ion's entry code use the abstract interface.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 706062 [details] [diff] [review]
Patch.

Review of attachment 706062 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinterp.cpp
@@ +316,5 @@
>  
>  #ifdef JS_ION
>      if (ion::IsEnabled(cx)) {
> +        ion::MethodStatus status = ion::CanEnter(cx, script, AbstractFramePtr(fp),
> +                                                 fp->isConstructing(), false);

What's the point in passing in fp->isConstructing() if |fp| itself is already passed in via AbstractFramePtr?

Comment 3

[Kannan Vijayan [:djvj]]

(In reply to Sean Stangl from comment #2)
> Comment on attachment 706062 [details] [diff] [review]
> Patch.
> 
> Review of attachment 706062 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jsinterp.cpp
> @@ +316,5 @@
> >  
> >  #ifdef JS_ION
> >      if (ion::IsEnabled(cx)) {
> > +        ion::MethodStatus status = ion::CanEnter(cx, script, AbstractFramePtr(fp),
> > +                                                 fp->isConstructing(), false);
> 
> What's the point in passing in fp->isConstructing() if |fp| itself is
> already passed in via AbstractFramePtr?

We can't get at that flag from a BaselineFrame pointer, so the abstraction doesn't expose it.  When baseline invokes ion compilation, it'll grab the isConstructing flag by walking its own stack and checking the bytecode op of the caller at the call-point for a JSOP_NEW.

Comment 4

[Kannan Vijayan [:djvj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb38771328da

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb38771328da