834456 - Clean up TinderboxPrints for non-talos

Status: RESOLVED DUPLICATE of bug 845388

(Tree Management Graveyard :: TBPL, defect)

Description

[Armen [:armenzg]]

This line does not show up on a tbpl summary:
12:34:40     INFO - TinderboxPrint: gaia_revision: <a href='http://hg.mozilla.org/integration/gaia-central/rev/038054b702cf'>038054b702cf</a>

Comment 1

[Ed Morley [:emorley]]

See bug 829145 comment 11 :-)

Comment 2

[Armen [:armenzg]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #1)
> See bug 829145 comment 11 :-)

Working in so many bugs concurrently made me miss it.

What would it be required to fix it?

[Bringing the comment forward]

(In reply to Ed Morley [:edmorley UTC+0] from comment #11)
> Note we'll also need to remove:
> https://hg.mozilla.org/webtools/tbpl/file/ac35be9cb467/js/MachineResult.
> js#l55
> 
> (Believe it was added ages ago due to having multiple revisions pasted in
> the logs; they've since been cleaned up so should be fine)

Comment 3

[Ed Morley [:emorley]]

Removing the |if (foo) return null;| from the linked line should do the trick.

Once bug 829145 is in production again, it will be easier to test the TBPL UI locally (checkout tbpl, remove that line, run index.html from the local filesystem) to be sure. 

(Still don't have my machine back up and running)

Comment 4

[Ed Morley [:emorley]]

Attachment: Patch v1

This gets rid of the spurious space after the "http:", but it still isn't linkified, since the TinderboxPrint output added by bug 829145 isn't in the same format as all the others (the latest version of the patch in that bug regressed the markup).

I don't really want to special-case the gaia revs (especially seeing as it will make it harder to run TBPL and tbplv2 in parallel without dirtying TBPLv2 too), so a buildbot followup will be required to fix this.

Comment 5

[Ed Morley [:emorley]]

In fact, I'm just going to save this cleanup for bug 845388, since without hardcoding the gaia rev case, there's no easy way to stop this regressing other types of TinderboxPrint (see the examples in bug 845388).