Drop livemarks support from FUEL

RESOLVED FIXED in Firefox 21

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: raymondlee)

Tracking

({addon-compat, dev-doc-complete})

unspecified
Firefox 21
addon-compat, dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

nsILivemarkService is being removed, and I suppose there's no interest in writing a wrapper for the new async API (and FUEL is not async afaik)
(Assignee)

Comment 1

5 years ago
Created attachment 709614 [details] [diff] [review]
v1

I couldn't find any references using it so I have just removed the livemarks getter in the file.

Pushed to try and looks good.
Attachment #709614 - Flags: review?(mak77)
Comment on attachment 709614 [details] [diff] [review]
v1

Review of attachment 709614 [details] [diff] [review]:
-----------------------------------------------------------------

yes, looks correct, I couldn't find any additional entry in mxr
Attachment #709614 - Flags: review?(mak77) → review+
Keywords: addon-compat, dev-doc-needed
(Assignee)

Comment 3

5 years ago
Created attachment 709720 [details] [diff] [review]
Patch for check-in
Assignee: nobody → raymond
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Attachment #709614 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Passed try
https://tbpl.mozilla.org/?tree=Try&rev=6963da39ac59
https://hg.mozilla.org/integration/mozilla-inbound/rev/df128dab6a05
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df128dab6a05
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
As no documentation has been written for FUEL Application, I simply added a note in https://developer.mozilla.org/en-US/docs/Firefox_21_for_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.