Last Comment Bug 834492 - Drop livemarks support from FUEL
: Drop livemarks support from FUEL
: addon-compat, dev-doc-complete
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 21
Assigned To: Raymond Lee [:raymondlee]
Depends on:
Blocks: 834457
  Show dependency treegraph
Reported: 2013-01-24 15:45 PST by Marco Bonardo [::mak]
Modified: 2013-02-07 06:07 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (1.73 KB, patch)
2013-02-03 23:53 PST, Raymond Lee [:raymondlee]
mak77: review+
Details | Diff | Splinter Review
Patch for check-in (1.68 KB, patch)
2013-02-04 07:46 PST, Raymond Lee [:raymondlee]
no flags Details | Diff | Splinter Review

Description User image Marco Bonardo [::mak] 2013-01-24 15:45:31 PST
nsILivemarkService is being removed, and I suppose there's no interest in writing a wrapper for the new async API (and FUEL is not async afaik)
Comment 1 User image Raymond Lee [:raymondlee] 2013-02-03 23:53:13 PST
Created attachment 709614 [details] [diff] [review]

I couldn't find any references using it so I have just removed the livemarks getter in the file.

Pushed to try and looks good.
Comment 2 User image Marco Bonardo [::mak] 2013-02-04 07:11:39 PST
Comment on attachment 709614 [details] [diff] [review]

Review of attachment 709614 [details] [diff] [review]:

yes, looks correct, I couldn't find any additional entry in mxr
Comment 3 User image Raymond Lee [:raymondlee] 2013-02-04 07:46:06 PST
Created attachment 709720 [details] [diff] [review]
Patch for check-in
Comment 4 User image Raymond Lee [:raymondlee] 2013-02-04 07:47:46 PST
Passed try
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2013-02-04 11:51:21 PST
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2013-02-04 16:32:48 PST
Comment 7 User image Jean-Yves Perrier [:teoli] 2013-02-07 06:07:45 PST
As no documentation has been written for FUEL Application, I simply added a note in

Note You need to log in before you can comment on or make changes to this bug.