We don't test for visibility or if the element can be scrolled to. We'll need to fully test out the click() function, and all of its possible exceptions.
We should port over the tests from https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/click_scrolling_tests.py and https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/click_tests.py to live in http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/unit/
Whiteboard: [good first bug][lang=py][mentor=automatedtester]
Hi! I'd like to tackle this one! Could you please point me to guide on how to setup everything for this project?
Follow the steps on https://developer.mozilla.org/en-US/docs/Simple_Firefox_build to get firefox built. Make the change as mentioned in comment 1. The tests can be copied across from the Selenium project (linked in comment 1) https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/Running_Tests for running the tests. Hope that helps!
Hm, it seems that tests in that file  are already ported to marionette , thus, I don't need to copy them one more time. Also, I think that it is a wrong test name here ? I looked over and there is nothing about cookies. So, it is only about porting scrolling tests from , right?  https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/click_tests.py  http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/unit/test_click.py  https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/click_tests.py#13  https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/click_scrolling_tests.py
Created attachment 8414650 [details] [diff] [review] 0001-Bug-834502-Need-to-cover-more-cases-in-test_click.py.patch Please, review. I ported tests for scrolling, but three of them are failing. At least two of those failures look like valid ones.
(In reply to akruglov from comment #5) >  > https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/ > common/click_tests.py#13 Copy paste error by the looks
(In reply to akruglov from comment #6) > Created attachment 8414650 [details] [diff] [review] > 0001-Bug-834502-Need-to-cover-more-cases-in-test_click.py.patch > > Please, review. > > I ported tests for scrolling, but three of them are failing. > At least two of those failures look like valid ones. Can you please disable the failing tests by putting @skip("Bug number") above the failing tests. Can you also raise separate bugs for each of the failing tests Thanks
Created attachment 8415025 [details] [diff] [review] 0001-Bug-834502-Need-to-cover-more-cases-in-test_click.py.patch marked failed tests with skip
pushed to try mobile https://tbpl.mozilla.org/?tree=Try&rev=719ca2661632 desktop https://tbpl.mozilla.org/?tree=Try&rev=a959d7673415 Will check back later on the results
Attachment #8415025 - Flags: review?(dburns) → review+
This has been landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/8e706d0a4193 Thanks for the hard work on this patch! The next step for this code is that it will be merged, if all goes well, into Mozilla central and this will be resolved fixed. If you want to work on another Marionette Good First Bug have a look at the bugs in https://bugzilla.mozilla.org/buglist.cgi?resolution=---&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=[good%20first%20bug]&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Marionette&product=Testing&list_id=10013678 If there are none that look appealing the Automation and Tools Team have another list at http://www.joshmatthews.net/bugsahoy/?automation=1&py=1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.