Closed Bug 834699 Opened 8 years ago Closed 8 years ago

Remove XBL scope pref

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

Once we enable XBL scopes in bug 834697 and wait long enough to be confident in them, we'll want to remove the pref machinery to allow for various refactoring and cleanup.
Attachment #744201 - Flags: review?(bzbarsky)
Attachment #744202 - Flags: review?(bzbarsky)
This is green.
Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

>--- a/content/base/src/nsINode.cpp
>+++ b/content/base/src/nsINode.cpp
>@@ -723,18 +722,17 @@ nsINode::GetUserData(JSContext* aCx, const nsAString& aKey, ErrorResult& aError)
> }
> 
> //static
> bool
> nsINode::ShouldExposeUserData(JSContext* aCx, JSObject* /* unused */)
> {
>   JSCompartment* compartment = js::GetContextCompartment(aCx);
>   return xpc::AccessCheck::isChrome(compartment) ||
>-         xpc::IsXBLScope(compartment) ||
>-         !XPCJSRuntime::Get()->XBLScopesEnabled();
>+         xpc::IsXBLScope(compartment);
> }

Could you rename the function back to IsChromeOrXBL()?
Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

r=me
Attachment #744201 - Flags: review?(bzbarsky) → review+
Comment on attachment 744202 [details] [diff] [review]
Fix tests that munge dom.xbl_scopes. v1

> +  // loading the real test. This stuff is no longer behind a test, but we just

s/behind a test/behind a pref/

r=me
Attachment #744202 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/d56decca3e60
https://hg.mozilla.org/mozilla-central/rev/e4074e65f6e2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.