834699 - Remove XBL scope pref

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Once we enable XBL scopes in bug 834697 and wait long enough to be confident in them, we'll want to remove the pref machinery to allow for various refactoring and cleanup.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Stop checking dom.xbl_scopes. v1

Comment 2

[Bobby Holley (:bholley)]

Attachment: Fix tests that munge dom.xbl_scopes. v1

Comment 3

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=4ca7b821e336

Comment 4

[Bobby Holley (:bholley)]

This is green.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

>--- a/content/base/src/nsINode.cpp
>+++ b/content/base/src/nsINode.cpp
>@@ -723,18 +722,17 @@ nsINode::GetUserData(JSContext* aCx, const nsAString& aKey, ErrorResult& aError)
> }
> 
> //static
> bool
> nsINode::ShouldExposeUserData(JSContext* aCx, JSObject* /* unused */)
> {
>   JSCompartment* compartment = js::GetContextCompartment(aCx);
>   return xpc::AccessCheck::isChrome(compartment) ||
>-         xpc::IsXBLScope(compartment) ||
>-         !XPCJSRuntime::Get()->XBLScopesEnabled();
>+         xpc::IsXBLScope(compartment);
> }

Could you rename the function back to IsChromeOrXBL()?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 744202 [details] [diff] [review]
Fix tests that munge dom.xbl_scopes. v1

> +  // loading the real test. This stuff is no longer behind a test, but we just

s/behind a test/behind a pref/

r=me

Comment 8

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d56decca3e60
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e4074e65f6e2

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d56decca3e60
https://hg.mozilla.org/mozilla-central/rev/e4074e65f6e2