The default bug view has changed. See this FAQ.

Remove XBL scope pref

RESOLVED FIXED in mozilla23

Status

()

Core
XPConnect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla23
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Once we enable XBL scopes in bug 834697 and wait long enough to be confident in them, we'll want to remove the pref machinery to allow for various refactoring and cleanup.
Blocks: 834701
Blocks: 834707
Blocks: 825392
Blocks: 857356
Created attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1
Created attachment 744202 [details] [diff] [review]
Fix tests that munge dom.xbl_scopes. v1
Attachment #744201 - Flags: review?(bzbarsky)
Attachment #744202 - Flags: review?(bzbarsky)
https://tbpl.mozilla.org/?tree=Try&rev=4ca7b821e336
This is green.
Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

>--- a/content/base/src/nsINode.cpp
>+++ b/content/base/src/nsINode.cpp
>@@ -723,18 +722,17 @@ nsINode::GetUserData(JSContext* aCx, const nsAString& aKey, ErrorResult& aError)
> }
> 
> //static
> bool
> nsINode::ShouldExposeUserData(JSContext* aCx, JSObject* /* unused */)
> {
>   JSCompartment* compartment = js::GetContextCompartment(aCx);
>   return xpc::AccessCheck::isChrome(compartment) ||
>-         xpc::IsXBLScope(compartment) ||
>-         !XPCJSRuntime::Get()->XBLScopesEnabled();
>+         xpc::IsXBLScope(compartment);
> }

Could you rename the function back to IsChromeOrXBL()?
Comment on attachment 744201 [details] [diff] [review]
Stop checking dom.xbl_scopes. v1

r=me
Attachment #744201 - Flags: review?(bzbarsky) → review+
Comment on attachment 744202 [details] [diff] [review]
Fix tests that munge dom.xbl_scopes. v1

> +  // loading the real test. This stuff is no longer behind a test, but we just

s/behind a test/behind a pref/

r=me
Attachment #744202 - Flags: review?(bzbarsky) → review+
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d56decca3e60
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e4074e65f6e2
https://hg.mozilla.org/mozilla-central/rev/d56decca3e60
https://hg.mozilla.org/mozilla-central/rev/e4074e65f6e2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.