Closed
Bug 834768
Opened 11 years ago
Closed 11 years ago
Fix signed/unsigned build warnings in signaling_unittests.cpp
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.39 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
{
media/webrtc/signaling/test/signaling_unittests.cpp:470:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
media/webrtc/signaling/test/signaling_unittests.cpp:763:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
|
Assignee | |
Comment 1•11 years ago
|
||
Just switch to using a size_t, which IIUC is the type that std::vector<>::size() returns.
|
||
Updated•11 years ago
|
Attachment #706457 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec05a370f01d
Flags: in-testsuite-
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec05a370f01d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•