The default bug view has changed. See this FAQ.

Video (ImageLayers?) not rotated correctly with hwc

RESOLVED FIXED in Firefox 21

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cjones, Assigned: diego)

Tracking

unspecified
mozilla21
x86_64
Linux
Points:
---

Firefox Tracking Flags

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 verified, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: [hwc-blocker])

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 706521 [details]
Screenshot

STR
 (1) Launch video app in portrait orientation
 (2) Load any video, let it play for a moment
 (3) Switch to landscape orientation

The image isn't rotated, it's instead scale-transformed out to the rotated bounds.
Whiteboard: [hwc-blocker]
(Assignee)

Updated

4 years ago
Assignee: nobody → dwilson
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Forgot to look at the world transform rotation :S The patch is simple. I'll share it ASAP
(Assignee)

Comment 2

4 years ago
Created attachment 706697 [details] [diff] [review]
Make HwcComposer2D honors world transform
Attachment #706697 - Flags: review?(jones.chris.g)
Comment on attachment 706697 [details] [diff] [review]
Make HwcComposer2D honors world transform

>diff --git a/widget/gonk/HwcComposer2D.cpp b/widget/gonk/HwcComposer2D.cpp

>+        //we find a fuzzy zero the same way as
>+        //PreservesAxisAlignedRectangles()

Nit: style would be

          // Compute fuzzy equal like PreservesAxisAlignedRectangles()

r=me with that.
Attachment #706697 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 706812 [details] [diff] [review]
Make HwcComposer2D honors world transform v2

Addressed nit from previous patch
Attachment #706697 - Attachment is obsolete: true
Attachment #706812 - Flags: review?(jones.chris.g)
Comment on attachment 706812 [details] [diff] [review]
Make HwcComposer2D honors world transform v2

(Code review point of order: if I say, "r=me with the above comments addressed", then I don't need to see the next patch that addresses the comments; you can take r+.  Especially for things like indentation or style changes.  But, always feel free to re-request review if you'd like.)
Attachment #706812 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 6

4 years ago
cjones,

I see. You've been kind enough to help me land all of these patches. What's does one usually do to get the it landed after it's been r+'ed?
Best is to set checkin-needed and wait for someone to snarf it.  Or if you need to escalate to someone with push access, like m1 ;).
Keywords: checkin-needed
Also, we should get you push access :).  Please file a bug on L1 [1]

[1] http://www.mozilla.org/hacking/committer/
https://hg.mozilla.org/mozilla-central/rev/a31b07df79df
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
This blocks enabling hwc, which is needed for shippable power-usage numbers.  This will either make into v1.0.0 through official gecko upstream or as a downstream patch to it.  Let's make everyone's lives easier and land upstream.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Please update status-b2g18 and status-b2g18-v1.0.0 to fixed once this has been uplifted to mozilla-b2g18 and mozilla-b2g18_v1_0_0 branches.
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → affected
https://hg.mozilla.org/releases/mozilla-b2g18/rev/5431cb750db1
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/ac5a6c368313
status-b2g18: affected → fixed
status-b2g18-v1.0.0: affected → fixed
status-firefox19: --- → wontfix
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
status-b2g18-v1.0.1: --- → fixed
I confirm the fix is verified on Ubuntu 13.04 x86 on FF 21RC4.
status-firefox21: fixed → verified
You need to log in before you can comment on or make changes to this bug.