Closed Bug 835007 Opened 8 years ago Closed 8 years ago
Should allow "all" in transition-property even if it's not the only value
The spec at http://dev.w3.org/csswg/css3-transitions/#transition-property says that "transition-property: all, margin-top" is valid as far as I can tell. But CSSParserImpl::ParseTransitionProperty doesn't allow that, and neither does CSSParserImpl::ParseTransition.
Note http://stackoverflow.com/questions/14533519/how-can-i-specify-a-css3-transition-to-all-properties-but-with-one-exception-ov for an example of how people want to use this.
Yeah, this was a change in the spec; I had a note in my todo list to deal with it, but hadn't filed a bug yet.
I have a patch in my patch queue; still needs tests.
TODO: needs tests
Attachment #712092 - Flags: review?(bzbarsky)
Comment on attachment 712092 [details] [diff] [review] Make 'transition-property: all' work as an item within a list. Hmm. We don't need transition manager changes to handle this? r=me on the parts that are here; might be good explaining in the checkin comment why the transition manager doesn't need changing.
Attachment #712092 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
FYI, there's a comment in CSSParserImpl::ParseTransition() that hasn't been updated. // + If there is more than one item, then none of the items can be // 'none' or 'all'. 'or 'all'' should probably be removed at some point. It did fool me to believe for a while that Firefox hadn't updated to the new behavior.
Thanks for pointing that out; I've stuck a patch to fix it in my queue, which I'll commit the next time I'm landing stuff.
Comment adjusted in https://hg.mozilla.org/integration/mozilla-inbound/rev/695c35eb1b8b
You need to log in before you can comment on or make changes to this bug.