835140 - Twitter 'slideshow' of user pictures won't load (Nightly 21)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jonathan]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130127 Firefox/21.0
Build ID: 20130127031042

Steps to reproduce:

Load a twitter user's profile page, then click on one of their photos.


Actual results:

Top twitter menu bar remains but rest of page remains blank - photo will not load.


Expected results:

Should go into twitter's so-called 'slideshow' mode (see twitter's URL with ..media/slideshow?url=... in it) with arrow keys left and right to navigate through user's photos.

Nightly 21 is broken - this works fine in both release 18 and beta 19.

Comment 1

[Alice0775 White]

STR:
1. Open https://twitter.com/agneschan
2. Click a thumbnail image

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/1d122eaa9070
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130119 Firefox/21.0 ID:20130119212613
Bad:
http://hg.mozilla.org/mozilla-central/rev/01c964705be7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130120 Firefox/21.0 ID:20130120124713
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1d122eaa9070&tochange=01c964705be7


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1d122eaa9070
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130119 Firefox/21.0 ID:20130119172511
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/88daef90f2ab
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130120 Firefox/21.0 ID:20130120015012
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1d122eaa9070&tochange=88daef90f2ab

Triggered by:
88daef90f2ab	Brian Hackett — Bug 821361 - Optimize type information in closures that only run once, r=luke.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: patch

This seems to fix the problem for me.  Without the patch the page eventually loads on my machine, though it takes some time.  The issue seems to be that we are doing lots of cloning of scripts that run multiple times but have been marked as running only once, dragging down performance.  That is because bug 835140 marks any (function() { ... })() script as only running once, even if the lambda appears within another function or within a loop.  The attached patch fixes this so that run once lambdas are only marked when they are defined in code that will itself only run once.

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 706946 [details] [diff] [review]
patch

D'oh

Comment 4

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb6e2dd0fa47

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/fb6e2dd0fa47

Comment 6

[Mitza]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:23.0) Gecko/20130421 Firefox/23.0  
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20130203 Firefox/21.0
Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20130203 Firefox/23.0

Verified as fixed on Firefox 21 (Build ID:20130416200523) and on Firefox latest nightly (Build ID:20130421031002).