Do we need support for the table[cols] attribute?

RESOLVED FIXED in mozilla21

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: dbaron)

Tracking

({dev-doc-complete})

Trunk
mozilla21
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
We have some code to support this attribute (e.g. <http://mxr.mozilla.org/mozilla-central/source/layout/style/nsRuleNode.cpp?rev=037363fa0258#6615>), but it's not clear to me it's good for anything.
(Assignee)

Comment 1

4 years ago
It seems the result of the style mapping is unused, though I'm currently compiling the full tree to check.  (This code might be mapping from either table or td, though.  See the comments in HTMLTableElement.cpp about how its attribute mapping is weird.)

(BTW, do any other browsers support the layout attribute?)
(Reporter)

Comment 2

4 years ago
Apparently Bernd thought so too.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 587458
(Assignee)

Comment 3

4 years ago
Created attachment 707232 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.
Attachment #707232 - Flags: review?(bzbarsky)
(Assignee)

Updated

4 years ago
Assignee: nobody → dbaron
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Duplicate of this bug: 587458
Comment on attachment 707232 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.

r=me
Attachment #707232 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

4 years ago
Created attachment 707426 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.
Attachment #707426 - Flags: review?(bzbarsky)
(Assignee)

Updated

4 years ago
Attachment #707232 - Attachment is obsolete: true
(Assignee)

Comment 7

4 years ago
The revised patch adds the changes to nsCSSPropList.h and makes no other changes.
Comment on attachment 707426 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.

r=me
Attachment #707426 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 9

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ebed8dbb21c
https://hg.mozilla.org/mozilla-central/rev/0ebed8dbb21c
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Keywords: dev-doc-needed
Yoshino-san updated:
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_21

As it wasn't documented elsewhere, and it was non-standard and quite cryptic, I don't think we need more doc. Switch back to dev-doc-needed if you disagree.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.