Closed
Bug 835169
Opened 13 years ago
Closed 13 years ago
Do we need support for the table[cols] attribute?
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Ms2ger, Assigned: dbaron)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
8.10 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
We have some code to support this attribute (e.g. <http://mxr.mozilla.org/mozilla-central/source/layout/style/nsRuleNode.cpp?rev=037363fa0258#6615>), but it's not clear to me it's good for anything.
|
Assignee | |
Comment 1•13 years ago
|
||
It seems the result of the style mapping is unused, though I'm currently compiling the full tree to check. (This code might be mapping from either table or td, though. See the comments in HTMLTableElement.cpp about how its attribute mapping is weird.)
(BTW, do any other browsers support the layout attribute?)
|
Reporter | |
Comment 2•13 years ago
|
||
Apparently Bernd thought so too.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #707232 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dbaron
|
||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 707232 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.
r=me
Attachment #707232 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #707426 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #707232 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•13 years ago
|
||
The revised patch adds the changes to nsCSSPropList.h and makes no other changes.
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 707426 [details] [diff] [review]
Remove unused mapping into style of table cols attribute.
r=me
Attachment #707426 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
|
||
Comment 10•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•12 years ago
|
Keywords: dev-doc-needed
|
|
||
Comment 11•12 years ago
|
||
Yoshino-san updated:
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_21
As it wasn't documented elsewhere, and it was non-standard and quite cryptic, I don't think we need more doc. Switch back to dev-doc-needed if you disagree.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•