Get rid of the remaining traces of nsPIDOMEventTarget

RESOLVED FIXED in mozilla21

Status

()

Core
DOM: Events
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Edwin)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
See <http://mxr.mozilla.org/mozilla-central/search?string=nsPIDOMEventTarget&find=&findi=&filter=&hitlimit=&tree=mozilla-central>
(Assignee)

Comment 1

4 years ago
Will be working on this bug.
(Assignee)

Comment 2

4 years ago
Created attachment 706907 [details] [diff] [review]
Proposed Patch

Proposed patch to bug 835171
(Reporter)

Comment 3

4 years ago
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

Review of attachment 706907 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventDispatcher.cpp
@@ +13,5 @@
>  #include "nsMutationEvent.h"
>  #include NEW_H
>  #include "nsFixedSizeAllocator.h"
>  #include "nsINode.h"
> +#include "nsIDOMWindow.h"

Please revert this change.
Attachment #706907 - Flags: review?(bugs)

Comment 4

4 years ago
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

># HG changeset patch
># Parent f18b1213915191887f57c98044c76eeea909daae
># User Edwin Casasola <edwincasasolar@yahoo.com>
>BugFix:  835171 Get rid of remaining traces of nsPIDOMEventTarget
>
>diff --git a/content/events/src/nsEventDispatcher.cpp b/content/events/src/nsEventDispatcher.cpp
>--- a/content/events/src/nsEventDispatcher.cpp
>+++ b/content/events/src/nsEventDispatcher.cpp
>@@ -9,17 +9,17 @@
> #include "nsPresContext.h"
> #include "nsEventListenerManager.h"
> #include "nsContentUtils.h"
> #include "nsError.h"
> #include "nsMutationEvent.h"
> #include NEW_H
> #include "nsFixedSizeAllocator.h"
> #include "nsINode.h"
>-#include "nsPIDOMWindow.h"
>+#include "nsIDOMWindow.h"
Don't do this change
Attachment #706907 - Flags: review?(bugs) → review+
(Reporter)

Comment 5

4 years ago
Edwin, could you update the patch to address that comment, and make the commit message something like

Bug 835171 - Get rid of remaining traces of nsPIDOMEventTarget; r=smaug

? Thanks!
Assignee: nobody → smartaled
(Assignee)

Comment 6

4 years ago
Yes of course, I Will get to it.
(Assignee)

Comment 7

4 years ago
Created attachment 707323 [details] [diff] [review]
Proposed Patch Revision

Proposed Patch Revision
(Reporter)

Comment 8

4 years ago
Great, thanks!
Keywords: checkin-needed

Comment 9

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f52d576e175b
https://hg.mozilla.org/mozilla-central/rev/f52d576e175b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.