835171 - Get rid of the remaining traces of nsPIDOMEventTarget

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

See <http://mxr.mozilla.org/mozilla-central/search?string=nsPIDOMEventTarget&find=&findi=&filter=&hitlimit=&tree=mozilla-central>

Comment 1

[Edwin]

Will be working on this bug.

Comment 2

[Edwin]

Attachment: Proposed Patch

Proposed patch to bug 835171

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

Review of attachment 706907 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventDispatcher.cpp
@@ +13,5 @@
>  #include "nsMutationEvent.h"
>  #include NEW_H
>  #include "nsFixedSizeAllocator.h"
>  #include "nsINode.h"
> +#include "nsIDOMWindow.h"

Please revert this change.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

># HG changeset patch
># Parent f18b1213915191887f57c98044c76eeea909daae
># User Edwin Casasola <[e-mail]>
>BugFix:  835171 Get rid of remaining traces of nsPIDOMEventTarget
>
>diff --git a/content/events/src/nsEventDispatcher.cpp b/content/events/src/nsEventDispatcher.cpp
>--- a/content/events/src/nsEventDispatcher.cpp
>+++ b/content/events/src/nsEventDispatcher.cpp
>@@ -9,17 +9,17 @@
> #include "nsPresContext.h"
> #include "nsEventListenerManager.h"
> #include "nsContentUtils.h"
> #include "nsError.h"
> #include "nsMutationEvent.h"
> #include NEW_H
> #include "nsFixedSizeAllocator.h"
> #include "nsINode.h"
>-#include "nsPIDOMWindow.h"
>+#include "nsIDOMWindow.h"
Don't do this change

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Edwin, could you update the patch to address that comment, and make the commit message something like

Bug 835171 - Get rid of remaining traces of nsPIDOMEventTarget; r=smaug

? Thanks!

Comment 6

[Edwin]

Yes of course, I Will get to it.

Comment 7

[Edwin]

Attachment: Proposed Patch Revision

Proposed Patch Revision

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Great, thanks!

Comment 9

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f52d576e175b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f52d576e175b