Last Comment Bug 835171 - Get rid of the remaining traces of nsPIDOMEventTarget
: Get rid of the remaining traces of nsPIDOMEventTarget
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla21
Assigned To: Edwin
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-27 12:46 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2013-01-29 06:47 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proposed Patch (7.43 KB, patch)
2013-01-27 14:09 PST, Edwin
bugs: review+
Details | Diff | Splinter Review
Proposed Patch Revision (7.41 KB, patch)
2013-01-28 15:30 PST, Edwin
no flags Details | Diff | Splinter Review

Comment 1 Edwin 2013-01-27 12:54:02 PST
Will be working on this bug.
Comment 2 Edwin 2013-01-27 14:09:40 PST
Created attachment 706907 [details] [diff] [review]
Proposed Patch

Proposed patch to bug 835171
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2013-01-28 01:46:25 PST
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

Review of attachment 706907 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventDispatcher.cpp
@@ +13,5 @@
>  #include "nsMutationEvent.h"
>  #include NEW_H
>  #include "nsFixedSizeAllocator.h"
>  #include "nsINode.h"
> +#include "nsIDOMWindow.h"

Please revert this change.
Comment 4 Olli Pettay [:smaug] (vacation Aug 25-28) 2013-01-28 05:34:33 PST
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

># HG changeset patch
># Parent f18b1213915191887f57c98044c76eeea909daae
># User Edwin Casasola <edwincasasolar@yahoo.com>
>BugFix:  835171 Get rid of remaining traces of nsPIDOMEventTarget
>
>diff --git a/content/events/src/nsEventDispatcher.cpp b/content/events/src/nsEventDispatcher.cpp
>--- a/content/events/src/nsEventDispatcher.cpp
>+++ b/content/events/src/nsEventDispatcher.cpp
>@@ -9,17 +9,17 @@
> #include "nsPresContext.h"
> #include "nsEventListenerManager.h"
> #include "nsContentUtils.h"
> #include "nsError.h"
> #include "nsMutationEvent.h"
> #include NEW_H
> #include "nsFixedSizeAllocator.h"
> #include "nsINode.h"
>-#include "nsPIDOMWindow.h"
>+#include "nsIDOMWindow.h"
Don't do this change
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2013-01-28 05:43:01 PST
Edwin, could you update the patch to address that comment, and make the commit message something like

Bug 835171 - Get rid of remaining traces of nsPIDOMEventTarget; r=smaug

? Thanks!
Comment 6 Edwin 2013-01-28 10:04:28 PST
Yes of course, I Will get to it.
Comment 7 Edwin 2013-01-28 15:30:02 PST
Created attachment 707323 [details] [diff] [review]
Proposed Patch Revision

Proposed Patch Revision
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2013-01-29 00:26:40 PST
Great, thanks!
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-01-29 06:47:46 PST
https://hg.mozilla.org/mozilla-central/rev/f52d576e175b

Note You need to log in before you can comment on or make changes to this bug.