Closed Bug 835171 Opened 9 years ago Closed 9 years ago

Get rid of the remaining traces of nsPIDOMEventTarget

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: Ms2ger, Assigned: smartaled)

Details

Attachments

(2 files)

Will be working on this bug.
Attached patch Proposed PatchSplinter Review
Proposed patch to bug 835171
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

Review of attachment 706907 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventDispatcher.cpp
@@ +13,5 @@
>  #include "nsMutationEvent.h"
>  #include NEW_H
>  #include "nsFixedSizeAllocator.h"
>  #include "nsINode.h"
> +#include "nsIDOMWindow.h"

Please revert this change.
Attachment #706907 - Flags: review?(bugs)
Comment on attachment 706907 [details] [diff] [review]
Proposed Patch

># HG changeset patch
># Parent f18b1213915191887f57c98044c76eeea909daae
># User Edwin Casasola <edwincasasolar@yahoo.com>
>BugFix:  835171 Get rid of remaining traces of nsPIDOMEventTarget
>
>diff --git a/content/events/src/nsEventDispatcher.cpp b/content/events/src/nsEventDispatcher.cpp
>--- a/content/events/src/nsEventDispatcher.cpp
>+++ b/content/events/src/nsEventDispatcher.cpp
>@@ -9,17 +9,17 @@
> #include "nsPresContext.h"
> #include "nsEventListenerManager.h"
> #include "nsContentUtils.h"
> #include "nsError.h"
> #include "nsMutationEvent.h"
> #include NEW_H
> #include "nsFixedSizeAllocator.h"
> #include "nsINode.h"
>-#include "nsPIDOMWindow.h"
>+#include "nsIDOMWindow.h"
Don't do this change
Attachment #706907 - Flags: review?(bugs) → review+
Edwin, could you update the patch to address that comment, and make the commit message something like

Bug 835171 - Get rid of remaining traces of nsPIDOMEventTarget; r=smaug

? Thanks!
Assignee: nobody → smartaled
Yes of course, I Will get to it.
Proposed Patch Revision
Great, thanks!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f52d576e175b
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.