835191 - Unprefix -moz-font-feature-settings

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Masatoshi Kimura [:emk]]

IE10 already unprefixed the property. There's no point in keeping the prefix.

Comment 1

[John Daggett (:jtd)]

They unprefixed it before the behavior was completely defined (e.g. which features are on by default).  I think unprefixing font-feature-settings should be tied to the prefixed font-variant properties, since we really want authors to use those *instead* of font-feature-settings.

Comment 2

[Masatoshi Kimura [:emk]]

No new prefixed properties should be added anymore, as suggested in <https://groups.google.com/d/topic/mozilla.dev.platform/34JfwyEh5e4/discussion>.
Instead, font-variant properties should be implemented and should be preffed-off on release and beta channels until the spec reaches CR.

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to John Daggett (:jtd) from comment #1)
> (e.g. which features are on by default).
I'm not sure what does that have to do with the prefix. It will affect the behavior even if (-moz-)font-feature-settings is not used at all because it is a default behavior.

Comment 4

[John Daggett (:jtd)]

I'm aware of that but in discussing this with dbaron I think we concluded that the font-variant-xxx subproperties should be an exception to that rule, mainly because -moz-font-feature-settings is already prefixed and the use of font-variant-xxx is a better alternative for general usage.

Comment 5

[John Daggett (:jtd)]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> (In reply to John Daggett (:jtd) from comment #1)
> > (e.g. which features are on by default).
> I'm not sure what does that have to do with the prefix. It will affect the
> behavior even if (-moz-)font-feature-settings is not used at all because it
> is a default behavior.

It highlights the risk that the IE team took in making this unprefixed, since they could potentially end up with something that doesn't match the spec-defined behavior.  The default settings policy was decided *after* IE10 shipped.  There are lots of interactions between font-feature-settings and the font-variant properties that I think are actually important to iron out.

Comment 6

[John Daggett (:jtd)]

Reducing the scope of the bug title to cover only what is not covered by the font-variant-xxx implementation bug, bug 549861.

Comment 7

[Florian Bender]

This essentially waits on enable-by-default of font-variant-* (layout.css.font-features.enabled).

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was fixed in https://hg.mozilla.org/mozilla-central/rev/0bab389db590

Comment 9

[Jean-Yves Perrier [:teoli]]

Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/34
and
https://developer.mozilla.org/en-US/docs/Web/CSS/font-feature-settings