[ko] Add Korean keyboard in Gaia on Firefox OS

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: channy, Assigned: BYUN Sangpil)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review | Splinter Review
(Reporter)

Description

6 years ago
We have to add Korean keyboard to Gaia user interface.
https://github.com/mozilla-b2g/gaia/tree/master/apps/keyboard/js
(Reporter)

Comment 1

5 years ago
I surveyed some of Korean IMEs based on Javascript.
1. http://ohi.kr/ and http://ohi.kr/ohi.js (GPL)
2. http://colspan.net/hangulime/ (MIT)
3. https://gist.github.com/wkpark/5310769 (New BSD)

Mr. Wonkyu Park developed #3 Saenaru IMEs and it's very good for me. 
If you can port it to Firefox OS, it'll be very nice works!
(Reporter)

Comment 2

5 years ago
For new team,

Check out the status of Gaia keyboard.
https://wiki.mozilla.org/Gaia/System/Keyboard/Layout#Known_implementations 
Develop together in https://github.com/mozillakr/gaia
(Reporter)

Comment 3

5 years ago
We want to consider adding "Hanson IME" by Son, Sangkil

Demo: http://www.zannavi.com/hanson/
Code: http://www.zannavi.com/work/hanson.tar.gz
License: GPL
(Reporter)

Updated

5 years ago
Assignee: hyeonseok → channy
QA Contact: channy → timdream
Component: ko / Korean → Gaia::Keyboard
Product: Mozilla Localizations → Boot2Gecko
If you would like to contribute to Gaia and have the IME added to the open source codebase, please make sure the open source license is comparable to Apache License.

https://github.com/mozilla-b2g/gaia/blob/master/LICENCE

So no GPL nor LGPL, AFAIK :-/
(Assignee)

Comment 5

5 years ago
Created attachment 818317 [details] [review]
link to the pull request

Review Please.
(Assignee)

Updated

5 years ago
Attachment #818317 - Attachment is patch: false
Attachment #818317 - Attachment mime type: text/plain → text/x-github-pull-request
Attachment #818317 - Flags: review+
(Reporter)

Comment 6

5 years ago
Comment on attachment 818317 [details] [review]
link to the pull request

Sangphil, review flag is not for you. :)
Attachment #818317 - Flags: review+ → review?(timdream)
Comment on attachment 818317 [details] [review]
link to the pull request

Thanks for the contribution!

As this is a simple Hangul keyboard layout with IME (no Hanja) I don't see major issue to check-in this first.

Rudy, :djf, could you check double check to see if this works for everyone?
Attachment #818317 - Flags: review?(timdream)
Attachment #818317 - Flags: review+
Attachment #818317 - Flags: feedback?(rlu)
Attachment #818317 - Flags: feedback?(dflanagan)
(Reporter)

Comment 8

5 years ago
Only typing Korean is the most of use cases in modern smart phone life in Korea except Hanja. :)
Hi Sangpil,

I am sorry that this bug does not land in time. However because of bug 884752 you would need to rebase your patch.

I've updated the documentation for you on that.
https://wiki.mozilla.org/Gaia/System/Keyboard/Layout
Assignee: channy → sangpire
Flags: needinfo?(sangpire)
(Assignee)

Comment 10

5 years ago
Hi Tim.

It's ok. And Thank you for the documentation.

I rebased my patch onto mozilla-b2g/master branch.
Please review again.

Thank you.
Flags: needinfo?(sangpire)
Comment on attachment 818317 [details] [review]
link to the pull request

Looks good!

The |keyboardGroups| part is dead code and due to be removed though.
Attachment #818317 - Flags: feedback?(rlu)
Attachment #818317 - Flags: feedback?(dflanagan)
master: https://github.com/mozilla-b2g/gaia/commit/987e1035d32ded28c830ad5867e38d6ee15e107a

Thank you!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

5 years ago
Thank you Tim.

Awesome!! Today is special day for me.
Thank you for helping that first contribution.
(Reporter)

Comment 14

5 years ago
How to enable Korean keyboard for testing in firefox 1.3 nightly? I updated recent nightly version in geeksphone, but there is no Korean keyboard.
Hi Channy, you'll have to make gaia with the keyboard env variable set to include Korean.

|GAIA_KEYBOARD_LAYOUTS?=en,ko make|

Or post this on the GeeksPhone forums as they're very reluctant to add new languages to their builds.

Comment 16

5 years ago
Done
(Reporter)

Comment 17

5 years ago
(In reply to Geeksphone from comment #16)
> Done

(In reply to Jan Jongboom [:janjongboom] from comment #15)
> Hi Channy, you'll have to make gaia with the keyboard env variable set to
> include Korean.
> 
> |GAIA_KEYBOARD_LAYOUTS?=en,ko make|
> 
> Or post this on the GeeksPhone forums as they're very reluctant to add new
> languages to their builds.

Thanks for Jan and Geeksphone!
http://forum.geeksphone.com/index.php?topic=5792.0
(Reporter)

Comment 18

4 years ago
(In reply to Geeksphone from comment #16)
> Done

Hi, Geeksphone.

I asked to add ko to the latest build on forum to test Korean keyboard.
Would you check again?
(Reporter)

Updated

4 years ago
Blocks: 994495
(Reporter)

Comment 19

4 years ago
I reopened for some reasons. Not yet fixed some of issues on v1.3 keyboard layout change Bug 994495 and not to ship Korean keyboard in default on Keon reference phone.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I am closing this bug because we generally don't REOPEN bug without reverting the patch.

If you want to track the progress of Keon on Bugzilla@Mozilla, file a bug under Firefox OS::Vencomm and mark [POVB] (Part of vendor build) on the whiteboard.

Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
QA Contact: timdream
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
No longer blocks: 994495
You need to log in before you can comment on or make changes to this bug.