835266 - [FM Radio] Missing favorite stations, and unable to select favorite

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Gaia:     6c53dfd2e5d60393f6a57e9e1a4b5af6a3d6a783
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/2226f181c8c2
BuildID   20130126070202
Version   18.0

STR:
0. Prepare some favorite stations. Then kill all apps.
1. Un-plug headphone.
2. Open FM-Radio app.
3. Plug-in headphone.

Expected result: 
Show favorite stations, and user can mark favorite.

Actual result:
Missing favorite stations. User unable to mark favorite.

Comment 1

[Askeing Yen[:askeing][:fyen]]

Youtube: http://youtu.be/QXdR0l5_tFk

Comment 2

[Andrew Overholt [:overholt]]

The video makes it seem that the favourite stations aren't stored if you kill the app.

Comment 3

[Marcia Knous [:marcia]]

Adding qawanted to investigate whether the behavior happens consistently or only in the conditions in the initial comment.

Comment 4

[Marcia Knous [:marcia]]

Unfortunately, I am getting inconsistent results when testing this on several different devices.

I was able to reproduce the STR in Comment 0 one one device. When I opened the FM radio and plugged in headphones after, I was missing my favorite stations and could not save any new FM stations. Note that the FM radio app is killed as well before you see this behavior.

I could also reproduce this bug as follows:

1. Start with a freshly flashed phone
2. Launch FM radio
3. Plug in headphones
4. Try to set a favorite station
5. I am not able to set a station.

I noticed that when I plug in the headphones before launching the app, things in general seem to work much better.

But there were other cases

Comment 5

[Tony Chung [:tchung]]

i retested comment 4 with the commercial RIL also with this build.   100% reproducible.

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/945b0ed70929
Gaia   0dcff9e1ff93d5c035f4a7b1bd28dd0e53792ef0
BuildID 20130129094039
Version 18.0

this is a regression, it used to work fine.   requesting blocking tef+, since its a easy and common step to launch the app and then plug in the headphones since thats what the error message is reminding the user to do.

Comment 6

[Andrew Overholt [:overholt]]

Steven, can you take this?

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking status-b2g18 and status-b2g18-v1.0.0 as affected, please update the status to fixed once this is verified landed on v1-train/mozilla-b2g18 and v1.0.0/mozilla-b2g18_v_1_0_0

Comment 8

[StevenLee[:slee]]

Hi Pin,

I can reproduce this bug. The problem is resulted from that favoritesList::_favList is null. I am not sure why it's null. You are more familiar with this topic. Can you take this?

Comment 9

[Pin Zhang [:pzhang] (inactive)]

Attachment: Github pull request 7939

Comment 10

[Pin Zhang [:pzhang] (inactive)]

It (In reply to Pin Zhang [:pzhang] from comment #9)
> Created attachment 709543 [details]
> Github pull request 7939

It's a regression caused by bug 828796, the favorite list is not initialized if the headset is no plugged-in when the FM App is opened.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 709543 [details]
Github pull request 7939

Would you mind writing a few tests for the app so it's less likely to regress in the future?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

What are the next steps here?  The deadline for landing blocker bugs is rapidly approaching (2/15) and getting this landed sooner rather than later to shake out any possible regressions would be ideal.

Comment 13

[David Scravaglieri [:scravag]]

21, I think this is ready to land! Check please.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/b29bdf154c2969ada67ff8727712ad18ebc54053

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: d50beefc8ef0660976207de673a1cb00efdc203d
v1.0.1: 71b0dbf8c449b2322e661e0fb80a09d52153b774

Comment 16

[Askeing Yen[:askeing][:fyen]]

Device:   Unagi
Gaia:     af67b0a6aa1aa7c4b09ea21b54b10ca4b74a4594
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/1afaccd266ec
BuildID   20130217070202
Version   18.0

Verified.