Closed Bug 835385 Opened 11 years ago Closed 11 years ago

GC: Fix for some jit test rooting analysis failures

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(2 files)

There seems to be a bunch of tests failing with rooting analysis failures, I think related to bug 834826.

This is a fix for the most obvious problem in jsfun.h.
Attached patch Proposed fixSplinter Review
Attachment #707090 - Flags: review?(terrence)
As mentioned earlier.  Moving the AutoEnterAnalysis before JS::ensureIonCompartmentExists() does the trick.
Attachment #707176 - Flags: review?(wmccloskey)
Attachment #707176 - Flags: review?(wmccloskey) → review+
Attachment #707090 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/280f2844d296
https://hg.mozilla.org/mozilla-central/rev/719e2132cc42
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: