835473 - gfxFontUtils.cpp:1054:1: warning: ‘bool ValidateLocaTable(const uint8_t*, uint32_t, uint32_t, int16_t, uint16_t)’ defined but not used [-Wunused-function]

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning:
{
gfx/thebes/gfxFontUtils.cpp:1054:1: warning: ‘bool ValidateLocaTable(const uint8_t*, uint32_t, uint32_t, int16_t, uint16_t)’ defined but not used [-Wunused-function]
}

Bug 833283 removed the last caller of this function, so the function itself can go too.

Comment 1

[Daniel Holbert [:dholbert]]

MXR search to prove that it's unused:
https://mxr.mozilla.org/mozilla-central/search?string=ValidateLocaTable

Comment 2

[Daniel Holbert [:dholbert]]

This all applies to the adjacent function "ValidateKernTable", too. MXR search for that one, showing that it's unused: https://mxr.mozilla.org/mozilla-central/search?string=ValidateKernTable

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 707218 [details] [diff] [review]
fix

Yup, the only code that used these was indeed removed by bug 833283. Thanks for cleaning up!

Comment 5

[Daniel Holbert [:dholbert]]

Sure -- thanks for the review!
 
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c84939daa28

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c84939daa28