Closed Bug 835473 Opened 7 years ago Closed 7 years ago

gfxFontUtils.cpp:1054:1: warning: ‘bool ValidateLocaTable(const uint8_t*, uint32_t, uint32_t, int16_t, uint16_t)’ defined but not used [-Wunused-function]

Categories

(Core :: Graphics: Text, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning:
{
gfx/thebes/gfxFontUtils.cpp:1054:1: warning: ‘bool ValidateLocaTable(const uint8_t*, uint32_t, uint32_t, int16_t, uint16_t)’ defined but not used [-Wunused-function]
}

Bug 833283 removed the last caller of this function, so the function itself can go too.
This all applies to the adjacent function "ValidateKernTable", too. MXR search for that one, showing that it's unused: https://mxr.mozilla.org/mozilla-central/search?string=ValidateKernTable
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #707218 - Flags: review?(jfkthame)
Blocks: 832545
Comment on attachment 707218 [details] [diff] [review]
fix

Yup, the only code that used these was indeed removed by bug 833283. Thanks for cleaning up!
Attachment #707218 - Flags: review?(jfkthame) → review+
Sure -- thanks for the review!
 
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c84939daa28
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/0c84939daa28
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.