835581 - ReferenceError: reference to undefined property Cc['@mozilla.org/xpcom/mac-utils;1'] in nsURLFormatter.js

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mats Palmgren (inactive)]

STEPS TO REPRODUCE
1. start an Aurora debug build on Linux64 with a fresh profile
2. Tools->Web Developer->Error Console

ACTUAL RESULTS
Warning: ReferenceError: reference to undefined property Cc['@mozilla.org/xpcom/mac-utils;1']
Source File: file:///OBJDIR/dist/bin/components/nsURLFormatter.js
Line: 43

Comment 1

[Marco Bonardo [:mak]]

it should either check if "@mozilla.org/xpcom/mac-utils;1" is in Cc, or be ifdef XP_MACOSX

Comment 2

[:Cykesiopka]

Attachment: Proposed Patch

Not sure if there's a better way to do this, but at least it works when I build for Linux64...

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 719421 [details] [diff] [review]
Proposed Patch

Review of attachment 719421 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, it's a long time I wanted to fix this but kept forgetting!

::: toolkit/components/urlformatter/nsURLFormatter.js
@@ +37,5 @@
>      let ABI = "default";
>      try {
>        ABI = this.appInfo.XPCOMABI;
>  
> +      if("@mozilla.org/xpcom/mac-utils;1" in Cc) {

please add a whitespace between if and the parenthesis

@@ +41,5 @@
> +      if("@mozilla.org/xpcom/mac-utils;1" in Cc) {
> +        // Mac universal build should report a different ABI than either macppc
> +        // or mactel.
> +        let macutils = Cc["@mozilla.org/xpcom/mac-utils;1"].
> +                        getService(Ci.nsIMacUtils);

while here please fix indentation, either getService aligned with Cc, or dot aligned with [ (these are the most common styles in the codebase)

Comment 4

[:Cykesiopka]

Attachment: Patch for check in

Addresses review comments.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89202194cc4f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/89202194cc4f