Closed Bug 835625 Opened 7 years ago Closed 7 years ago

Remove the MSVC exemption for FAIL_ON_WARNINGS in /gfx/gl

Categories

(Core :: Graphics, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I think attachment 703882 [details] [diff] [review] fixed the last MSVC build warnings in /gfx/gl that were requiring the MSVC check in that directory's Makefile.

So, we can probably remove the MSVC exemption in gfx/gl/Makefile.in now.
Attached patch fix v1Splinter Review
Here's the patch. Try run, to be sure it works:
  https://tbpl.mozilla.org/?tree=Try&rev=808ba8a1342e
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 707377 [details] [diff] [review]
fix v1

aaaand it's green!
Attachment #707377 - Flags: review?(bgirard)
Comment on attachment 707377 [details] [diff] [review]
fix v1

:D
Attachment #707377 - Flags: review?(bgirard) → review+
OS: Linux → Windows 7
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/84540e4ecbea
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.