Closed
Bug 835625
Opened 13 years ago
Closed 13 years ago
Remove the MSVC exemption for FAIL_ON_WARNINGS in /gfx/gl
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
671 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I think attachment 703882 [details] [diff] [review] fixed the last MSVC build warnings in /gfx/gl that were requiring the MSVC check in that directory's Makefile.
So, we can probably remove the MSVC exemption in gfx/gl/Makefile.in now.
|
Assignee | |
Comment 1•13 years ago
|
||
Here's the patch. Try run, to be sure it works:
https://tbpl.mozilla.org/?tree=Try&rev=808ba8a1342e
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
sorry, wrong Try link.
Corrected Try link: https://tbpl.mozilla.org/?tree=Try&rev=8501e22a134c
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 707377 [details] [diff] [review]
fix v1
aaaand it's green!
Attachment #707377 -
Flags: review?(bgirard)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 707377 [details] [diff] [review]
fix v1
:D
Attachment #707377 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Flags: in-testsuite-
|
|
Assignee | |
Updated•13 years ago
|
OS: Linux → Windows 7
Hardware: x86_64 → All
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•