835635 - nsPrintDialogGTK.cpp:343:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Build warnings in nsPrintDialogGTK.cpp:
{
widget/gtk2/nsPrintDialogGTK.cpp: In function 'void ShowCustomDialog(GtkComboBox*, gpointer)':
widget/gtk2/nsPrintDialogGTK.cpp:50:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
widget/gtk2/nsPrintDialogGTK.cpp: In member function 'const char* nsPrintDialogWidgetGTK::OptionWidgetToString(GtkWidget*)':
widget/gtk2/nsPrintDialogGTK.cpp:343:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
widget/gtk2/nsPrintDialogGTK.cpp:345:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

This is because we compare 'gint' values to a macro that evaluates to ArrayLength() (which returns unsigned).

Trivial fix -- just add a gint cast to the macro.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d633b6a8d43

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d633b6a8d43