835666 - ARIA combobox selected value is not a part of name computation

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

another part of bug 819273 (same description):

it's needed for ARIA test suite: https://dvcs.w3.org/hg/pfwg/raw-file/tip/ARIA/1.0/tests/test-files/accessible-name-input/checkbox-label-embedded-combobox.html

we should pick up an accessible name from accessible value. For example,

<input type="checkbox" id="test" />
   	<label for="test">Flash the screen 
   		<div role="combobox">
   			<div role="textbox"></div>
   			<div role="listbox">
   				<div role="option">1</div>
   				<div role="option" aria-selected="true">2</div>
   				<div role="option">3</div>
   			</div>
   		</div>
   		times.
   	</label>

input's name should be "Flash the screen 2 times".

We miss combobox value because NameFromSubtree for selected item returns null if we are in recursion.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

add compressWhitespace otherwise the algorithm adds the space into the end of computed value

Comment 3

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/eec9adfe786f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eec9adfe786f