83570 - XUL popups can appear below dock

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

on osx, popups can be positioned so that part of them are below the dock. this
makes them impossible to access.

the solution is to use ::GetAvailableWindowPositioningBounds() from CarbonLib
1.3 in nsScreenMac instead of simply checking the GDHandle. Luckily, the bounds
we get back are a rect since gecko can't handle regions in any of the window
positioning code.

Comment 1

[Adam]

This is also a problem for tooltips for the status bar buttons. Should that be a
separate bug or can it be thrown in with this?

Comment 2

[Ari]

This is one of those particularly annoying interface bugs.

Comment 3

[Mike Pinkerton (not reading bugmail)]

nominating for branch, this should be an easy kill after looking at the code.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: use OS calls to remove dock/menubar

Comment 5

[Mike Pinkerton (not reading bugmail)]

patch attached that uses ::GetAvailableWindowPositioningBounds() to sub out the
dock and the menubar. removes our code that does this for carbon builds only.

needing r/sr. this is a safe patch, and big bang for the buck.

Comment 6

[Steve Dagley]

r=sdagley

Comment 7

[Mike Pinkerton (not reading bugmail)]

Attachment: same patch, more lines of context

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 50567 [details] [diff] [review]
same patch, more lines of context

sr=sfraser

Comment 9

[lchiang]

per PDT email thread, mark PDT+.  Does this also affect OS besides OS X?

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed on branch, waiting for trunk to open.

Comment 11

[Mike Pinkerton (not reading bugmail)]

on trunk now

Comment 12

[John Morrison]

verified fixed 9.4 branch for xul popups, including tooltips, not extending 
below/behind the dock