Last Comment Bug 835773 - Align stepUp() and stepDown() implementation to HTML spec
: Align stepUp() and stepDown() implementation to HTML spec
Status: NEW
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
http://www.whatwg.org/specs/web-apps/...
Depends on:
Blocks: 636627
  Show dependency treegraph
 
Reported: 2013-01-29 04:36 PST by Mounir Lamouri (:mounir)
Modified: 2014-09-01 08:53 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Mounir Lamouri (:mounir) 2013-01-29 04:36:05 PST
For the moment, the difference I see with the specs are:
- http://html5.org/tools/web-apps-tracker?from=7644&to=7645 (we leave if we have no value instead of using value=0);
- we tend to clamp very often (value < min or value > man), I think the speak is less aggressive than us regarding clamping.

I'm fine with fixing the first part to follow the specs. I believe our behaviour regarding clamping is better though.
Comment 1 Mounir Lamouri (:mounir) 2013-01-29 04:40:35 PST
Looking a bit more, I see three things that I would like to change in the specs:
- point 6: I think we should use the lower value if we go up and the higher if we go down. The idea is that value=3, min=0 step=2, stepUp() should go to 4 and stepDown() to 2;
- point 7: we should not leave but do value = minimum;
- point 8: we should not leave but do value = maximum.
Comment 2 Mounir Lamouri (:mounir) 2013-01-29 04:45:08 PST
Actually, the issue in point 6 is that it doesn't take into account stepUp(n) and stepDown(n) with n>1. In that case, it will do a stepUp(1) and stepDown(1) (with th expected behaviour). To fix that, we should simply round the opposite way (not like the spec say, but as my previous comment say) and then run the steps that are in "Otherwise".
Comment 3 Mounir Lamouri (:mounir) 2013-01-30 10:38:26 PST
Comments sent to the list:
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2013-January/038821.html

Note You need to log in before you can comment on or make changes to this bug.