Closed Bug 835854 Opened 9 years ago Closed 9 years ago

Job symbols on build-system are broken after bug 831710

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Bug 831710 reordered some of the regexes in Data.js

Unfortunately this means that "build" matches against "build-system" in the buildername.

eg:

"Rev4 MacOSX Lion 10.7 build-system opt test mochitest-browser-chrome" -> "Build bc", "Bbc".

We could just restore the order for the "build" regex back to how it was, however this means that we'd still falsely match in the case of:
"... build-system opt test some-yet-unrecognised-test-name"

Instead, let's just explicitly exclude build-system.
Attached patch Patch v1Splinter Review
Looks fine locally :-)
Attachment #707671 - Flags: review?(philringnalda)
Comment on attachment 707671 [details] [diff] [review]
Patch v1

Maybe for TBPL Two: The One That Isn't a Reverse-Engineered Hack, we could just have builds-4hr *tell* us the tbpl_rowname, tbpl_jobname and tbpl_jobletter, so we don't have to remember every currently-running one, remember every time one no longer runs, and predict every future one?
Attachment #707671 - Flags: review?(philringnalda) → review+
Yeah good idea, added to the list that I have locally (that will get transposed to the wiki.m.o page soon).

https://hg.mozilla.org/webtools/tbpl/rev/3de321da020c
Depends on: 836290
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.