835854 - Job symbols on build-system are broken after bug 831710

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Bug 831710 reordered some of the regexes in Data.js

Unfortunately this means that "build" matches against "build-system" in the buildername.

eg:

"Rev4 MacOSX Lion 10.7 build-system opt test mochitest-browser-chrome" -> "Build bc", "Bbc".

We could just restore the order for the "build" regex back to how it was, however this means that we'd still falsely match in the case of:
"... build-system opt test some-yet-unrecognised-test-name"

Instead, let's just explicitly exclude build-system.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Looks fine locally :-)

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 707671 [details] [diff] [review]
Patch v1

Maybe for TBPL Two: The One That Isn't a Reverse-Engineered Hack, we could just have builds-4hr *tell* us the tbpl_rowname, tbpl_jobname and tbpl_jobletter, so we don't have to remember every currently-running one, remember every time one no longer runs, and predict every future one?

Comment 3

[Ed Morley [:emorley]]

Yeah good idea, added to the list that I have locally (that will get transposed to the wiki.m.o page soon).

https://hg.mozilla.org/webtools/tbpl/rev/3de321da020c

Comment 4

[Ed Morley [:emorley]]

In production :-)