835907 - DNT preferences "Learn more" link opens in new window

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Guilherme Lima]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130129 Firefox/21.0
Build ID: 20130129030851

Steps to reproduce:

Go to Options -> Privacy -> Tracking
Click on Learn More


Actual results:

A new window is opened with https://www.mozilla.org/en-US/dnt/


Expected results:

A new tab

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

This was done intentionally, but it's inconsistent with other links in the preferences window.

Comment 2

[Sid Stamm [:geekboy or :sstamm]]

Interesting.  I manually tested it on Mac and Linux, and both opened in a new tab (not window).  Guess I should have manually tested Windows too.

FWIW, being a front-end idiot I am, I copied the link pattern from the sync.xul panel (the links that open the privacy policy).  Maybe we should clean those up too?

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 707745 [details] [diff] [review]
patch

r+ assuming you update in-content/privacy.js & .xul too. :)

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Sid Stamm [:geekboy or :sstamm] from comment #2)

> FWIW, being a front-end idiot I am, I copied the link pattern from the
> sync.xul panel (the links that open the privacy policy).  Maybe we should
> clean those up too?

Those are a bit different, since they're actually doing JS stuff open clicking the "link" (ie, it's basically a button + oncommand), whereas here it's a straight-up Web 1.0 style link to a document.

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/261ff4b8bb22

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/261ff4b8bb22