Closed
Bug 836157
Opened 11 years ago
Closed 11 years ago
Contacts API: Remove unused indexes
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(1 file, 1 obsolete file)
30.57 KB,
patch
|
bent.mozilla
:
review+
overholt
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
Currently a save call for a single contact takes around 600 - 1000 msec. 550 msec out of 600 takes the actual transaction to finish. If we remove all indexes we get down to around 140 msec.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → anygregor
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #708209 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #708213 -
Flags: review?(bent.mozilla)
Comment on attachment 708213 [details] [diff] [review] patch Review of attachment 708213 [details] [diff] [review]: ----------------------------------------------------------------- Yay! ::: dom/base/IndexedDBHelper.jsm @@ +58,5 @@ > }; > > req.onupgradeneeded = function (aEvent) { > + if (DEBUG) debug("Database needs upgrade:" + self.dbName + aEvent.oldVersion + aEvent.newVersion); > + if (DEBUG) debug("Correct new database version:" + aEvent.newVersion == this.dbVersion); Nit: Combine in one DEBUG check ::: dom/contacts/fallback/ContactDB.jsm @@ +53,1 @@ > objectStore.createIndex("familyName", "properties.familyName", { unique: false, multiEntry: true }); You know, while you're here... :) You could remove the 'unique: false' from all of these (that's the default). If you want to leave them it's ok too. @@ -105,5 @@ > if (!objectStore) { > objectStore = aTransaction.objectStore(STORE_NAME); > } > - // Delete old email index. > - objectStore.deleteIndex("email"); Hm, I think you should leave this, since if the email index does exist you're going to do a bunch of work below that will cause the index to update itself.
Attachment #708213 -
Flags: review?(bent.mozilla) → review+
Updated•11 years ago
|
blocking-b2g: --- → tef?
Comment 4•11 years ago
|
||
Comment on attachment 708213 [details] [diff] [review] patch [Triage Comment] Let's not block the release on this but let's take this.
Attachment #708213 -
Flags: approval-mozilla-b2g18+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/aba3331a5c54
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aba3331a5c54
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/1b0ff92f64fa
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-firefox19:
--- → wontfix
status-firefox20:
--- → wontfix
status-firefox21:
--- → fixed
Comment 8•11 years ago
|
||
Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.
status-b2g18-v1.0.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•