836157 - Contacts API: Remove unused indexes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Currently a save call for a single contact takes around 600 - 1000 msec.
550 msec out of 600 takes the actual transaction to finish.
If we remove all indexes we get down to around 140 msec.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 708213 [details] [diff] [review]
patch

Review of attachment 708213 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!

::: dom/base/IndexedDBHelper.jsm
@@ +58,5 @@
>      };
>  
>      req.onupgradeneeded = function (aEvent) {
> +      if (DEBUG) debug("Database needs upgrade:" + self.dbName + aEvent.oldVersion + aEvent.newVersion);
> +      if (DEBUG) debug("Correct new database version:" + aEvent.newVersion == this.dbVersion);

Nit: Combine in one DEBUG check

::: dom/contacts/fallback/ContactDB.jsm
@@ +53,1 @@
>          objectStore.createIndex("familyName", "properties.familyName", { unique: false, multiEntry: true });

You know, while you're here... :)

You could remove the 'unique: false' from all of these (that's the default). If you want to leave them it's ok too.

@@ -105,5 @@
>          if (!objectStore) {
>            objectStore = aTransaction.objectStore(STORE_NAME);
>          }
> -        // Delete old email index.
> -        objectStore.deleteIndex("email");

Hm, I think you should leave this, since if the email index does exist you're going to do a bunch of work below that will cause the index to update itself.

Comment 4

[Andrew Overholt [:overholt]]

Comment on attachment 708213 [details] [diff] [review]
patch

[Triage Comment]
Let's not block the release on this but let's take this.

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aba3331a5c54

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aba3331a5c54

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/1b0ff92f64fa

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.