836182 - Fix mtransport usages of gtest.h templates w/ mixed-sign types

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

I get these build warnings for gtest.h template invocations where we're comparing two things w/ different signed-ness, when building current m-c and m-i:
{
 0:41.89 In file included from /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/ice_unittest.cpp:31:0:
 0:41.89 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: In instantiation of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]’:
 0:41.89 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1440:30:   required from ‘static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; bool lhs_is_null_literal = false]’
 0:41.89 /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/ice_unittest.cpp:317:5:   required from here
 0:41.89 Warning: -Wsign-compare in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: comparison between signed and unsigned integer expressions
 0:41.89 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1403:3: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
 0:41.90 In file included from /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/sctp_unittest.cpp:31:0:
 0:41.90 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: In instantiation of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int]’:
 0:41.90 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1440:30:   required from ‘static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int; bool lhs_is_null_literal = false]’
 0:41.90 /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/sctp_unittest.cpp:184:5:   required from here
 0:41.90 Warning: -Wsign-compare in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: comparison between signed and unsigned integer expressions
 0:41.90 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1403:3: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
 0:41.98 In file included from /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/transport_unittests.cpp:37:0:
 0:41.98 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: In instantiation of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]’:
 0:41.98 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1440:30:   required from ‘static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; bool lhs_is_null_literal = false]’
 0:41.98 /scratch/work/builds/mozilla-inbound/mozilla/media/mtransport/test/transport_unittests.cpp:131:5:   required from here
 0:41.99 Warning: -Wsign-compare in /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: comparison between signed and unsigned integer expressions
 0:41.99 /scratch/work/builds/mozilla-inbound/mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1403:3: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

Comment 1

[Daniel Holbert [:dholbert]]

(sorry for the unreadability of comment 0; it's very ugly, and that's why I'd love to have these warnings fixed. :))

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

In two of the three cases, we're comparing to a numeric literal, which (by default) is treated as signed when we instantiate the template -- but we can add a "u" suffix to make the value unsigned instead.

In the third case, we're comparing an int to a size_t. I just cast the int to size_t, and I added a check to make sure it's nonnegative.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(oops, previous fix accidentally had "> 0" instead of ">= 0" in the non-negative check.)

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/daa83b83531c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/daa83b83531c