836269 - In the Form Submit Observer, use fullZoom from nsIDOMWindowUtils rather than inferring zoom from CSS to device pixel ratio

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

See Bug 674373 pt 5 - provide a fullZoom API in nsIDOMWindowUtils, and use this rather than inferring zoom from CSS to device pixel ratio.
<https://hg.mozilla.org/mozilla-central/rev/550641381dfa>

Bug 674373 Comment 294:

> fullZoom is approximately the same as nsIMarkupDocumentViewer.fullZoom but
> takes into account quantization (and/or other limits imposed by Gecko).

Comment 1

[Philip Chee]

Attachment: Patch 1.0 one line fix.

I can't see any difference with or without my patch - which means of course it's working (I think). FWIW the form submit tests we have all pass, but I doubt that they exercise this path at all.

Formsubmit tests:
browser_bug561636.js
browser_bug595507.js 

TEST_PATH=suite/browser/test/browser_bug561636.js pymake -C ../objdir-sm/ mochitest-browser-chrome
INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 38
        Failed: 0
        Todo: 0

TEST_PATH=suite/browser/test/browser_bug595507.js pymake -C ../objdir-sm/ mochitest-browser-chrome
INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 3
        Failed: 0
        Todo: 0

Comment 2

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/90fb92893b25