836293 - Lockscreen wallpaper is not updated after changing homescreen wallpaper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Anthony Ricaud (:rik)]

STR:
1. Change your homescreen wallpaper with any method (long press on the homescreen, in the settings app, in the gallery directly)
2. Lock your phone

Expected:
Lockscreen displays the new wallpaper.

Actual:
Old wallpaper is still displayed.
After a reboot, the lockscreen wallpaper is the right one.

I think this is a regression of bug 829075

Comment 1

[Marcia Knous [:marcia]]

This works for me using the latest nightly build, 2013-01-30. I am using a freshly flashed device.

Comment 2

[Anthony Ricaud (:rik)]

This is only on the master branch of Gaia. I've found the issue and yes, it is related to bug 829075.

Comment 3

[Anthony Ricaud (:rik)]

Attachment: Pointer to https://github.com/mozilla-b2g/gaia/pull/7908

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 708611 [details] [diff] [review]
Pointer to https://github.com/mozilla-b2g/gaia/pull/7908

Can you write the test part (checkFirstCanvas and checkSecondCanvas) so it's more understandable? I think it *might* work but my brain is not very good at running Javascript :)

Please re-request for review afterward, thank you!

Comment 5

[Anthony Ricaud (:rik)]

Comment on attachment 708611 [details] [diff] [review]
Pointer to https://github.com/mozilla-b2g/gaia/pull/7908

I renamed the methods and changed the calls a bit.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 708611 [details] [diff] [review]
Pointer to https://github.com/mozilla-b2g/gaia/pull/7908

Thanks!

Comment 7

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/7f655a193dcbcb475762d27db54f6cc8bab0ba74

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 708611 [details] [diff] [review]
Pointer to https://github.com/mozilla-b2g/gaia/pull/7908

This one needs to be uplifted in order to uplift bug 829075

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 36a3144e44679b0f840b15450d7e1af6a7680b4a

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to John Ford [:jhford] from comment #9)
> v1-train: 36a3144e44679b0f840b15450d7e1af6a7680b4a

Correction:

v1-train: 27bfddddd1d99f91b17dd9c7aaad9f9c496dca7c

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Lukas Blakk [:lsblakk] from comment #11)
> Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

I reverted it on v1-train and v1.0.1 because of a 10mb overhead...