836298 - Conditional pause on exceptions

Status: NEW

(DevTools :: Debugger, enhancement, P5)

Description

[Rob Campbell [:rc] (:robcee)]

This would be an augmentation of the Pause on Exceptions feature in the Debugger. We would like a way to break on type of exception. E.g., break on StackOverflow.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

We can use the conditional breakpoints mechanism, after bug 812172 is done.

Comment 2

[Yehuda Katz]

If there is possible conditionally, Is there a reason not to break on StackOverflow under normal "break on exception" conditions?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

It works fine for me:
http://jsbin.com/eninec/1

Checking the "Pause on exceptions" option and clicking the button causes the debugger to pause with an InternalError exception.

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 836298 - Add conditional pause on exception

Review commit: https://reviewboard.mozilla.org/r/78154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78154/

Comment 5

[Rob Wu [:robwu]]

^ patch that implements the feature, together with "$scriptUrl" and "$exception" variables.

Comment 6

[Rob Wu [:robwu]]

Comment on attachment 8790239 [details]
Bug 836298 - Add conditional pause on exception

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78154/diff/1-2/

Comment 7

[Rob Wu [:robwu]]

Comment on attachment 8790239 [details]
Bug 836298 - Add conditional pause on exception

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78154/diff/2-3/

Comment 8

[James Long (:jlongster)]

Comment on attachment 8790239 [details]
Bug 836298 - Add conditional pause on exception

https://reviewboard.mozilla.org/r/78154/#review77426

Hey Rob,

I hate to do this but we are not investing in the old debugger anymore. The old test suite particularly is in bad shape and doesn't run very well on our build infrastructure because it's too heavy. We should avoid changing the old debugger because right now we know that it works and it's something that people can fallback on if the new debugger is broken (by flipping a pref).

Sorry that you did all this work without knowing this. If you'd like to contribute to the new debugger, see here: https://github.com/devtools-html/debugger.html We're early on in the process, so it may be a little while before we are ready for an advanced feature like this (we don't even have popups yet), but feel free to file an issue and we can help mentor.