Closed Bug 836303 Opened 7 years ago Closed 7 years ago

sctp_unittest.cpp:265:22: warning: private field 'peer_' is not used [-Wunused-private-field] (also 'gathering_complete_' and 'to_send_')

Categories

(Core :: WebRTC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

Attachments

(1 file, 1 obsolete file)

Build warnings for sctp_unittest.cpp:
{
../../../../media/mtransport/test/sctp_unittest.cpp:265:22: warning: private field 'peer_' is not used [-Wunused-private-field]
  TransportTestPeer *peer_;
                     ^
../../../../media/mtransport/test/sctp_unittest.cpp:269:8: warning: private field 'gathering_complete_' is not used [-Wunused-private-field]
  bool gathering_complete_;
       ^
../../../../media/mtransport/test/sctp_unittest.cpp:271:10: warning: private field 'to_send_' is not used [-Wunused-private-field]
  size_t to_send_;
         ^
3 warnings generated.
}

These are all for the class "TransportTestPeer".   It looks like there are other classes defined in this .cpp file that have & use similar member-variables, so these were probably just copypaste cruft (or perhaps formerly-used vairables).
These warnings are from clang, and they're visible in this build log:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=19265538&tree=Try
Attached patch fix (obsolete) — Splinter Review
Attachment #708137 - Flags: review?(ekr)
Attached patch fix v2Splinter Review
(oops, previous version had 1 extra line removed that wasn't supposed to be.)
Assignee: nobody → dholbert
Attachment #708137 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #708137 - Flags: review?(ekr)
Attachment #708138 - Flags: review?(ekr)
Blocks: 836355
Whiteboard: [WebRTC] [blocking-webrtc-]
Comment on attachment 708138 [details] [diff] [review]
fix v2

Review of attachment 708138 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #708138 - Flags: review?(ekr) → review+
https://hg.mozilla.org/mozilla-central/rev/c23e34b50930
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.