836303 - sctp_unittest.cpp:265:22: warning: private field 'peer_' is not used [-Wunused-private-field] (also 'gathering_complete_' and 'to_send_')

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warnings for sctp_unittest.cpp:
{
../../../../media/mtransport/test/sctp_unittest.cpp:265:22: warning: private field 'peer_' is not used [-Wunused-private-field]
  TransportTestPeer *peer_;
                     ^
../../../../media/mtransport/test/sctp_unittest.cpp:269:8: warning: private field 'gathering_complete_' is not used [-Wunused-private-field]
  bool gathering_complete_;
       ^
../../../../media/mtransport/test/sctp_unittest.cpp:271:10: warning: private field 'to_send_' is not used [-Wunused-private-field]
  size_t to_send_;
         ^
3 warnings generated.
}

These are all for the class "TransportTestPeer".   It looks like there are other classes defined in this .cpp file that have & use similar member-variables, so these were probably just copypaste cruft (or perhaps formerly-used vairables).

Comment 1

[Daniel Holbert [:dholbert]]

These warnings are from clang, and they're visible in this build log:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=19265538&tree=Try

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(oops, previous version had 1 extra line removed that wasn't supposed to be.)

Comment 4

[Eric Rescorla (:ekr)]

Comment on attachment 708138 [details] [diff] [review]
fix v2

Review of attachment 708138 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c23e34b50930

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c23e34b50930