836391 - fsmdef.c sends back the wrong error for create answer

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P5)

Description

[Adam Roach [:abr]]

In fsmdef.c, under fsmdef_ev_createanswer(), the following code is used to check for successful retrieval of ICE parameters:

>    vcm_res = vcmGetIceParams(dcb->peerconnection, &ufrag, &ice_pwd);
>    if (vcm_res) {
>        FSM_DEBUG_SM(DEB_F_PREFIX"vcmGetIceParams returned an error\n",
>            DEB_F_PREFIX_ARGS(FSM, __FUNCTION__));
>      ui_create_offer(evCreateAnswerError, line, call_id,
>          dcb->caller_id.call_instance_id, strlib_empty());
>      return (fsmdef_release(fcb, cause, FALSE));
>    }

The "ui_create_offer()" should be "ui_create_answer()". This is unlikely to show up in actual use, as the call to get ICE parameters is very unlikely to fail.

Comment 1

[Adam Roach [:abr]]

Fixed with the landing of Bug 860012