If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

fsmdef.c sends back the wrong error for create answer

RESOLVED FIXED

Status

()

Core
WebRTC: Signaling
P5
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: abr, Assigned: abr)

Tracking

21 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

(Assignee)

Description

5 years ago
In fsmdef.c, under fsmdef_ev_createanswer(), the following code is used to check for successful retrieval of ICE parameters:

>    vcm_res = vcmGetIceParams(dcb->peerconnection, &ufrag, &ice_pwd);
>    if (vcm_res) {
>        FSM_DEBUG_SM(DEB_F_PREFIX"vcmGetIceParams returned an error\n",
>            DEB_F_PREFIX_ARGS(FSM, __FUNCTION__));
>      ui_create_offer(evCreateAnswerError, line, call_id,
>          dcb->caller_id.call_instance_id, strlib_empty());
>      return (fsmdef_release(fcb, cause, FALSE));
>    }

The "ui_create_offer()" should be "ui_create_answer()". This is unlikely to show up in actual use, as the call to get ICE parameters is very unlikely to fail.
(Assignee)

Updated

5 years ago
Depends on: 860012
(Assignee)

Comment 1

5 years ago
Fixed with the landing of Bug 860012
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.