Last Comment Bug 836396 - Tests in ecma/Date/15.9.5.24 ignore local start time
: Tests in ecma/Date/15.9.5.24 ignore local start time
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla23
Assigned To: André Bargull
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-30 10:46 PST by André Bargull
Modified: 2013-04-05 13:38 PDT (History)
2 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Apply local time correction before computing utc time (7.25 KB, patch)
2013-01-30 10:48 PST, André Bargull
jwalden+bmo: review+
Details | Diff | Splinter Review

Description André Bargull 2013-01-30 10:46:57 PST
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

The test cases in ecma/Date/15.9.5.24 ignore the local start time when computing the final utc time, cf. [ES5.1 - 15.9.5.28] for the correct algorithm. 

I cannot provide a concrete test case which exhibits this problem, but it is noticeable in Australian time zones.
Comment 1 André Bargull 2013-01-30 10:48:51 PST
Created attachment 708221 [details] [diff] [review]
Apply local time correction before computing utc time
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2013-04-03 11:55:33 PDT
Comment on attachment 708221 [details] [diff] [review]
Apply local time correction before computing utc time

Review of attachment 708221 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, my head hurts reading this.  I've stared at this for hours and not really made any progress toward understanding it.  But I don't see that the changes you've made are actually *wrong* in any way, so I guess I'll just rubberstamp this and move on -- I've spent too much time on this already.  Hopefully specs will get to the point where we can make all these algorithms use real data, then we can get rid of the pseudo-accurate bogus garbage algorithm and tests.  :-\
Comment 3 Jeff Walden [:Waldo] (remove +bmo to email) 2013-04-04 14:51:37 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a65a4e4b385d
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-04-05 13:38:07 PDT
https://hg.mozilla.org/mozilla-central/rev/a65a4e4b385d

Note You need to log in before you can comment on or make changes to this bug.