Tests in ecma/Date/15.9.5.24 ignore local start time

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: André Bargull, Assigned: André Bargull)

Tracking

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

The test cases in ecma/Date/15.9.5.24 ignore the local start time when computing the final utc time, cf. [ES5.1 - 15.9.5.28] for the correct algorithm. 

I cannot provide a concrete test case which exhibits this problem, but it is noticeable in Australian time zones.
(Assignee)

Updated

4 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

4 years ago
Created attachment 708221 [details] [diff] [review]
Apply local time correction before computing utc time
Attachment #708221 - Flags: review?(jwalden+bmo)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 708221 [details] [diff] [review]
Apply local time correction before computing utc time

Review of attachment 708221 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, my head hurts reading this.  I've stared at this for hours and not really made any progress toward understanding it.  But I don't see that the changes you've made are actually *wrong* in any way, so I guess I'll just rubberstamp this and move on -- I've spent too much time on this already.  Hopefully specs will get to the point where we can make all these algorithms use real data, then we can get rid of the pseudo-accurate bogus garbage algorithm and tests.  :-\
Attachment #708221 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a65a4e4b385d
Assignee: general → andrebargull
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla23
https://hg.mozilla.org/mozilla-central/rev/a65a4e4b385d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.