836417 - sut_verifying doesn't allow enough time for SUTagent to start

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Jake Watkins [:dividehex]]

SUTAGent is a bit delay when it comes to starting up (atleast this is what I've seen with android).  We should probably allow sut_verifying to wait awhile before checking.  Otherwise, this causes devices to always end up in failed_sut_verifying after a reimage.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I wonder if it should just retry a few times, rather than waiting.  The only reason we wait to ping is to avoid false positives from uboot.  Presumably there won't be any SUT false positives from uboot!

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Hm, it does retry three times, but it does so immediately, rather than waiting for the full 180s timeout.  We're also going through the android_rebooting and android_pinging states first, which doesn't make a lot of sense for android systems.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug836417.patch

Comment 4

[Jake Watkins [:dividehex]]

Comment on attachment 709206 [details] [diff] [review]
bug836417.patch

WFM