836505 - GPS not turning off

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I don't have very good STR, but I launched Camera a few times, and launched Maps.  The phone was idle for a while.  This is on unagi.

I noticed Maps running in the background and killed it.  Camera is dead.  GPS is still running.

Nom blocking because likely power issue.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

To be clearer, I mean that GPS is *active* (white icon in status bar).

Disabling GPS through settings didn't turn it off.  Enabling airplane mode didn't turn it off.

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Hmm.. with newest gaia (1d73b9a2c) the Camera does not ask for geolocation anymore.

Comment 3

[Andrew Overholt [:overholt]]

QA:  if we can increase the R of the STR that would be awesome.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This worked for me this morning:

 1. Launch Maps app.
 2. Wait a few seconds
 3. Open task tray and kill Maps
 4. Goto (1)

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

i have Google Maps from E.me (local) added to my home screen.
i just have to launch Google Map and once GPS indicator shows up, press home to homescreen. GPS indicator stays there (even if i kill Google Maps from task view)

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I noticed if you select "Remember my choice" as no then it will shut off... 
if you select "Remember my choice" it will take longer for it to turn off...

STR:
1. launch browser
2. go to maps.google.com
3. select "Remember my choice" as yes
4. Allow for geolocation
5. kill the browser app using the task tray.
6. turn off geolocation in the settings... 

the geolocation stays there only for about 1 minute.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Cjones does it stay on for like 3 minutes?  or does it never turn off?

FYI: I respond fastest with the needmoreinfo? flag.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

GPS was on (bright white, active) earlier today after I used maps last night.  (And of course maps was long since killed.)  "Forever".

Comment 9

[Andrew Overholt [:overholt]]

How are things going here, Kan-Ru?

Comment 10

[Kan-Ru Chen [:kanru] (UTC+9)]

I have seen this on my dogfood phone. But I can't reproduce it now with latest b2g18 gecko :-/

Comment 11

[Kan-Ru Chen [:kanru] (UTC+9)]

Hmm.. found another STR

 1. Open both Camera and Maps
 2. Kill them all

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

Hmm.. found another STR

 1. Open both Camera and Maps
 2. Kill them all

Comment 13

[Kan-Ru Chen [:kanru] (UTC+9)]

I/Gecko   (  575): ###!!! [Child][AsyncChannel] Error: Channel closing: too late to send/recv, messages will be lost

This line looks very suspicious.

Comment 14

[Kan-Ru Chen [:kanru] (UTC+9)]

We send "starting" event multiple times but "shutdown" only once.

Comment 15

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: We don't care about the active count but only the active state.

Comment 16

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: We don't care about the active count but only the active state. v1.1

Fix the comment.

Comment 17

[[:fabrice] Fabrice Desré]

Comment on attachment 710502 [details] [diff] [review]
We don't care about the active count but only the active state. v1.1

Review of attachment 710502 [details] [diff] [review]:
-----------------------------------------------------------------

So, if appA and appB use the GPS, what happens if:
- appA starts
- appB starts
- appA stops

With your patch we consider that there is no GPS activity anymore, while appB is still using it?

Comment 18

[Kan-Ru Chen [:kanru] (UTC+9)]

When appB is still using it there will have no shutdown event.

The events look like:

- appA starts -> starting
- appB starts -> starting
- appA stops
- appB stops -> shutdown

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27b7363290b7

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27b7363290b7

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/7afd414d8aba
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/551169a85ee0