836561 - Significant time (~10 samples, ~15ms) in ConsoleAPI.js in b2g process on critical startup path

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The console is supposed to be disabled by default; I realized I've been testing with the equivalent of an eng build of gaia for convenience.

However, I'm filing this to compare with console disabled.  If we're nuking it at the right place, all this overhead should go away, but I'm not sure we're doing that.

This is being logged from window_manager.js createFrame().

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The amount of time consumed in this call seems to fluctuate quite a bit, for unclear reasons.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

As not-unexpected, disabling the console in Settings doesn't make this overhead go away.  Bye bye log message!

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Kill redundant log message that's showing up in profiles

(Review to whomever sees it first.  Trivial.)

This message doesn't provide new information anymore, because
 - all interesting apps run out-of-process
 - running apps can be seen with adb shell b2g-ps
 - failure to start an app will show up in dmesg

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 708394 [details] [diff] [review]
Kill redundant log message that's showing up in profiles

Please remember to request for uplift (to v1-train/v1.0.0)

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://github.com/mozilla-b2g/gaia/commit/1d940810b850a4413574da7bde1ad1b7845bf8c9

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 708394 [details] [diff] [review]
Kill redundant log message that's showing up in profiles

Trivial patch that saves time on the critical startup path.  Zero risk.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 708394 [details] [diff] [review]
Kill redundant log message that's showing up in profiles

(Not a gaia bug per se, but better to use the gaia tracking metadata I guess.)

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 708394 [details] [diff] [review]
Kill redundant log message that's showing up in profiles

Talking in triage we decided to block this so it can be uplifted to both v1-train and v1.0.0 branches - we want this low risk perf win.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 29356c322e0c94d851bfbd510d01462d82e6c970
v1.0.0: 43c6dff635a74e498f59923cc6936e58331c293a

Comment 10

[amiller]

does not make sense to create a regression issue.

Comment 11

[Darren]

Cannot verify, need steps to blackbox test the issue.