836586 - Anonymous user download/installs are properly not tracked.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Statistics, defect)

Description

[Wraithan (Chris McDonald) [:wraithan]]

Split from https://bugzilla.mozilla.org/show_bug.cgi?id=833880

Because the unique_together of Installed ( https://github.com/mozilla/zamboni/blob/master/mkt/webapps/models.py#L850 ) anonymous users are only tracked if they are using a different client.

I suggest we add a field anon_uuid or something of the sort. We set the uuid on the anon's session then if they try to install again we don't track them. Helps mitigate abuse potential and makes it so if a user actually does just reinstall it we don't end up tracking that.

Comment 1

[Andy McKay]

I'm loathe to use the Installed table for extra data.

For monolith we were thinking of storing the data in a temporary table and then pulling it out. Hashing the session is a fine idea. This could be the start of that code. So cc'ing Alexis.

Comment 2

[Alexis Metaireau (:alexis)]

Currently, for monolith, we're reading the data from the stats_* tables, and we don't care for now who is putting the data there, or how.

We where thinking about putting this data to a temporary table at some point, but we'll not do that for now, so I suggest you just add this field, and I'll consider it when retrieving the data on the monolith-aggregator side.

Comment 3

[Andrew Williamson [:eviljeff]]

What's the plan on this bug guys?  I'd imagine a good chunk of our downloads are anonymous so missing those makes the statistics we have now rather useless.

Comment 4

[fmalenfant]

Attachment: iis log install stats from mozilla marketplace

I filtered my log to keep the "install" from the mozilla marketplace.  If someone create an account, we redirect it (302), so I left only the status code "200", that is viewed when we got the first visite from a firefox marketplace app user.

Comment 5

[fmalenfant]

What I see in my console
https://marketplace.firefox.com/app/aceproject/statistics/installs/?last=30
does not reflect what I get in my iis log file.

Comment 6

[Alexis Metaireau (:alexis)]

I think Wraithan is currently adding support for this directly in the zamboni code, and we will get it from here to feed the information in the monolith db.

I don't know if wraithan already has a patch for this?

Comment 7

[Wraithan (Chris McDonald) [:wraithan]]

I don't have a patch for this, got pulled for some other stuff. I am at a work week but I can find some time in the evening to fix this.

Comment 8

[Hanno Schlichting]

Give Wraithan some points for this - feel free to downgrade to a 1 point, if you think this is easier than I think it is ;)

Comment 9

[Andy McKay]

Alexis is working on the temporary tables and API.

Comment 10

[Alexis Metaireau (:alexis)]

This had been fixed already by https://github.com/mozilla/zamboni/commit/2c5879f8694735e67a85475173c6787f9aa738fd and then by https://github.com/mozilla/zamboni/blob/master/mkt/receipts/views.py#L121