836589 - "New Tab" input switches from numbers to letters after one digit

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

21.0a1 (Trunk) Nightly from 2013-01-30
Nexus 4 phone with Android 4.2.1

Steps to reproduce:
- Click "New Tab"
- Switch keyboard to number mode
- Enter "12" in the input field

Actual results:
After entering "1" the keyboard switched to letter mode so you entered "1w"

Expected results:
Keyboard stays in number mode and you successfully entered 12

Comment 1

[Aaron Train [:aaronmt]]

It seems like this only happens when there is a current value; this is reproducible by just tapping on the AwesomeBar, no need for a new tab.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Lazily switch between AwesomeBar search and URL modes (v1)

This patch makes us switch between search and URL modes only when we are certain the text has a new mode. In ambiguous cases where the text can be either search or URL, we keep the current status. This way, we will not try to switch modes when the user is in the middle of inputting numbers.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 710754 [details] [diff] [review]
Lazily switch between AwesomeBar search and URL modes (v1)

hm... does this mean if I enter "http:", the keyboard would still switch from symbol mode to letter mode as soon as I get to the colon, thus requiring a switch back to symbol mode for the slashes?

why are you doing anything at all to the keyboard?

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Christian :Biesinger (don't email me, ping me on IRC) from comment #3)
> Comment on attachment 710754 [details] [diff] [review]
> Lazily switch between AwesomeBar search and URL modes (v1)
> 
> hm... does this mean if I enter "http:", the keyboard would still switch
> from symbol mode to letter mode as soon as I get to the colon, thus
> requiring a switch back to symbol mode for the slashes?

When you tap on the AwesomeBar, it's already in URL mode. So there would be no switch in that case.

> why are you doing anything at all to the keyboard?

I think it was mostly for UX. Many keyboards show different keys for URL mode and text mode. The user can enter either a URL or a search in the AwesomeBar, and depending on what we think the user is entering, we want to the keyboard to adapt to that. This feature was originally introduced in Fennec 11.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 710754 [details] [diff] [review]
Lazily switch between AwesomeBar search and URL modes (v1)

Review of attachment 710754 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AwesomeBar.java
@@ +337,5 @@
>              int optionBits = mText.getImeOptions() & ~EditorInfo.IME_MASK_ACTION;
>              mText.setImeOptions(optionBits | imeAction);
>  
> +            mDelayRestartInput = imeAction == EditorInfo.IME_ACTION_GO &&
> +                                 InputMethods.shouldDelayAwesomebarUpdate(mText.getContext());

use a couple parenthesis to make this a bit more readable

::: mobile/android/base/util/StringUtils.java
@@ +18,5 @@
>       *  foo.c
>       *  :foo
>       *  http://foo.com bar
>      */
>      public static boolean isSearchQuery(String text) {

just fix the one other caller to pass in wasSearchQuery

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Lazily switch between AwesomeBar search and URL modes (v1.1)

Addressed review comments.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c362e5037dcc

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c362e5037dcc