836593 - Better characterize samples spent creating mozbrowser resources

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

If you look at a profile of b2g-process side app startup, for example

http://people.mozilla.com/~bgirard/cleopatra/#report=0e6042fb2a6121d84a71796bfe27ec4275c1a9db

(under window_manager.js appendFrame()), there's a lot of uncharacterized "stuff".  I'd like to better see what's going where; FrameLoader creation vs. mozbrowser setup, for starters.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Add labels to organize samples under StartLoading() and BindToTree()

I wouldn't expect either of these methods to be "hot", but let me know if they might be.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

More informative profile

http://people.mozilla.com/~bgirard/cleopatra/#report=90b5c3acda2f990fd68b34dab42c0623a1a53d8b

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 708407 [details] [diff] [review]
Add labels to organize samples under StartLoading() and BindToTree()

These shouldn't be super hot.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Separate out the TabParent creation code

Now we can see what's going on in TryRemoteBrowser() vs. the rest of ReallyStartLoading().

http://people.mozilla.com/~bgirard/cleopatra/#report=b4bd24515490b34fbbc10cb139e15a8dc5874f7d

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4d3b9cafc9e

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We somehow didn't have sampler.h in nsFrameLoader on trunk

https://hg.mozilla.org/integration/mozilla-inbound/rev/0aecad4aa758

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4d3b9cafc9e
https://hg.mozilla.org/mozilla-central/rev/0aecad4aa758

Comment 8

[Julien Wajsberg [:julienw]]

Should this go to the various b2g18 branches ?

Comment 9

[Justin Lebar (not reading bugmail)]

Only if someone is profiling on the b2g18 branches, which I don't think we're actively doing at the moment.

Comment 10

[Julien Wajsberg [:julienw]]

Gabriele, do you think we need this ?

Comment 11

[Gabriele Svelto [:gsvelto] (PTO)]

Performance improvements for 1.0.1 are now down to Gaia mostly and I don't think we want to land any other major changes on Gecko mozilla-b2g18 as it would be quite risky. So with no major platform changes expected I would assume we won't be doing more profiling on b2g18 and so we don't need those patches.