Closed Bug 836593 Opened 7 years ago Closed 7 years ago
Better characterize samples spent creating mozbrowser resources
If you look at a profile of b2g-process side app startup, for example http://people.mozilla.com/~bgirard/cleopatra/#report=0e6042fb2a6121d84a71796bfe27ec4275c1a9db (under window_manager.js appendFrame()), there's a lot of uncharacterized "stuff". I'd like to better see what's going where; FrameLoader creation vs. mozbrowser setup, for starters.
I wouldn't expect either of these methods to be "hot", but let me know if they might be.
Assignee: nobody → jones.chris.g
Attachment #708407 - Flags: review?(bugs)
More informative profile http://people.mozilla.com/~bgirard/cleopatra/#report=90b5c3acda2f990fd68b34dab42c0623a1a53d8b
Comment on attachment 708407 [details] [diff] [review] Add labels to organize samples under StartLoading() and BindToTree() These shouldn't be super hot.
Attachment #708407 - Flags: review?(bugs) → review+
Now we can see what's going on in TryRemoteBrowser() vs. the rest of ReallyStartLoading(). http://people.mozilla.com/~bgirard/cleopatra/#report=b4bd24515490b34fbbc10cb139e15a8dc5874f7d
Attachment #708410 - Flags: review?(justin.lebar+bug)
Attachment #708410 - Flags: review?(justin.lebar+bug) → review+
7 years ago
We somehow didn't have sampler.h in nsFrameLoader on trunk https://hg.mozilla.org/integration/mozilla-inbound/rev/0aecad4aa758
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Should this go to the various b2g18 branches ?
Only if someone is profiling on the b2g18 branches, which I don't think we're actively doing at the moment.
Gabriele, do you think we need this ?
Performance improvements for 1.0.1 are now down to Gaia mostly and I don't think we want to land any other major changes on Gecko mozilla-b2g18 as it would be quite risky. So with no major platform changes expected I would assume we won't be doing more profiling on b2g18 and so we don't need those patches.
You need to log in before you can comment on or make changes to this bug.