836624 - Remove "getFaviconForPage" and "getFaviconDataAsDataURL" in "test_bookmarks_html.js"

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Raymond Lee [:raymondlee]]

Pushed to try. https://tbpl.mozilla.org/?tree=Try&rev=5a5aebdcb9ed

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 708904 [details] [diff] [review]
v1

Review of attachment 708904 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/unit/test_bookmarks_html.js
@@ +344,5 @@
> +              base64EncodeString(String.fromCharCode.apply(String, aData));
> +            do_check_true(base64Icon == aExpected.icon);
> +            deferred.resolve();
> +        });
> +        deferred.promise;

would be better to return deferred.promise explicitly here, just for clarify.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=3b38afec565c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57d4156eb9c3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57d4156eb9c3