836686 - Test failure 'testDisablePlugin is not defined' in restartTests/testAddons_pluginDisabledAfterRestart/test2.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is a spelling issue in restartTests/testAddons_pluginDisabledAfterRestart/test2.js which causes us to fail the test if no plugin is active.

http://mozmill-crowd.blargon7.com/#/functional/report/72e15dc943833b8fcba70aeb51fb0aef

Failure: testDisablePlugin is not defined

http://hg.mozilla.org/qa/mozmill-tests/file/8d2428a3cc14/tests/functional/restartTests/testAddons_pluginDisabledAfterRestart/test2.js#l15

Instead of testDisablePlugin it has to be testPluginDisabled.

Comment 1

[Bernhard M. Wiedemann]

Attachment: patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 708604 [details] [diff] [review]
patch

Review of attachment 708604 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet. Thanks Bernhard. I will land this now. Please let me know if that fixes the failures for you. I would like to get this backported then.

http://hg.mozilla.org/qa/mozmill-tests/rev/892c5d2345d3 (default)

Bernhard, if you provide another patch in the future please make sure that your name is set as the author of the patch. I missed to set it when I pushed the patch. :/ If you want me to correct it please let me know. Otherwise I will take care of it for the backports.

Comment 3

[Bernhard M. Wiedemann]

today's run with current version worked fine:
http://mozmill-crowd.blargon7.com/#/functional/report/0dbaa964aec88a2f5637c68c9668ecdf

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks a lot Bernhard. The backports have been landed:

http://hg.mozilla.org/qa/mozmill-tests/rev/52e1b2591937 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/6697988270f3 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/dacb9879c6cd (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/586a62f86233 (esr17)

Comment 5

[Bernhard M. Wiedemann]

http://openqa.opensuse.org/openqa/permanent/mozmill-2013-02-02.ogv
has the mozmill run starting at 05:30 ending at 09:31