Closed
Bug 836688
Opened 13 years ago
Closed 13 years ago
BaselineCompiler: Fix GetPcScript bug
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Silly bug. We weren't monitoring the return value of calls correctly, because the cache lookup used the return address into the (shared) stub and not the one into the JS frame. This patch also passes the script and pc to TypeScript::Monitor: to avoid looking it up a second time.
Attachment #708511 -
Flags: review?(kvijayan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 708511 [details] [diff] [review]
Patch
Review of attachment 708511 [details] [diff] [review]:
-----------------------------------------------------------------
Nice find.
Attachment #708511 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•