Closed Bug 836688 Opened 10 years ago Closed 10 years ago

BaselineCompiler: Fix GetPcScript bug

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
2.43 KB, patch
djvj
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
Silly bug. We weren't monitoring the return value of calls correctly, because the cache lookup used the return address into the (shared) stub and not the one into the JS frame. This patch also passes the script and pc to TypeScript::Monitor: to avoid looking it up a second time.
Attachment #708511 - Flags: review?(kvijayan)
Comment on attachment 708511 [details] [diff] [review]
Patch

Review of attachment 708511 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find.
Attachment #708511 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/0c67202199c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.