836732 - Buttons in pdf.js remain in hover state after selection

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Virgil Dicu [:virgil] [QA]]

Attachment: State of Print button after selection

Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130131 Firefox/21.0

1. Have pdf.js enabled
2. Load http://www.stluciadance.com/prospectus_file/sample.pdf
3. Select Print
4. Select Cancel in the Print dialog

Actual result: Print button remains in hover state until next click within the page.

Happens with all buttons.

Comment 1

[Virgil Dicu [:virgil] [QA]]

Not a regression, happens with F16 as well if I enable pdf.js. Didn't find any similar reports in bugzilla.

Comment 2

[Virgil Dicu [:virgil] [QA]]

Changing to minor issue. Occurs across branches: Beta, Aurora, Nightly.

Comment 3

[Kory M]

Hi there! I am a University of Toronto compsci student interested in picking this bug up as my first Mozilla bug. Can I claim this? Also, I would love if anyone can mentor me on this!

Comment 4

[alfredsod]

This issue seems to be caused by the affected buttons using :focus in addition to :hover so that buttons appear hovered when tabbed to. Changing :focus to :focus-active for buttons and listboxes seem to fix this for me. I won't pretend I understand all of the CSS, though.

Comment 5

[Kenan]

confirming with Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0 BUILD: 20211226092042

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/14516

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/bff7eb8ce8cbef35b631adc395a95654f5d2fb4b

Commit merged into master by GitHub
Authored by Jonas Jenwald (Snuffleupagus)