83675 - P12 import doesn't ask for token if smart card installed.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Javier Delgadillo]

I tried importing a p12 blob onto a smart card and the cert manager never asked
me what token to put the certs onto.  It just automatically chose the internal slot.

We should fix this, soon.

Comment 1

[Javier Delgadillo]

->p1

Comment 2

[Javier Delgadillo]

Attachment: patch that prompts for token during P12 import.

Comment 3

[Javier Delgadillo]

Ignore the portion of the patch in nsSecureBrowserUIImpl.cpp

Comment 4

[Stephane Saux]

Some questions:
Is this bug preventing all testing of cards? (i.e., is the import function a
prerequisite to the testing of the other functions)?
When can we expect publicly downloadable builds that include this fix?  How can
I help speed this process?

Comment 5

[David P. Drinan]

Assigning this bug to mcgreer.

Comment 6

[Ian McGreer]

r=mcgreer

Comment 7

[Javier Delgadillo]

I haven't tested that export still works with this patch.

Got sidetracked by another issue when I came up with this patch.

Comment 8

[Ian McGreer]

oops, jumped the gun.  I thought this bug was just for import.

Comment 9

[Javier Delgadillo]

taking bug

Comment 10

[Javier Delgadillo]

Attachment: Updated patch

Comment 11

[Ian McGreer]

r=mcgreer

Comment 12

[Christopher Blizzard (:blizzard)]

+nsPKCS12Blob::nsPKCS12Blob():mTmpFile(nsnull),
+                             mTmpFilePath(nsnull),
+                             mTokenSet(PR_FALSE)
 {
-  mToken = nsnull;
-  mCertArray = nsnull;
   mUIContext = new PipUIContext();
-  mTmpFile = NULL;
-  mTmpFilePath = NULL;
 }


Did you mean to remove mCertArray from the initialization list?

Fix that ( or respond to it ) and you have an sr=blizzard.

Comment 13

[Javier Delgadillo]

Good catch.  I've added initializing mCertArray back to the constructor of
nsPKCS12Blob.

Comment 14

[Javier Delgadillo]

Attachment: Updated patch

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Javier Delgadillo]

Patch checked in.

Comment 17

[John Unruh]

Verified fixed.

Comment 18

[Stephane Saux]

PDT for PSM

Comment 19

[Stephane Saux]

PDT+ as per Steve Elmeer 6/20/2001

Comment 20

[Stephane Saux]

whiteboard->verified.

Comment 21

[John Unruh]

Reopening. This is happening again to me. 11/9 Win98 trunk build.

Comment 22

[John Unruh]

Fixed. The iButton was not initialized.

Comment 23

[John Unruh]

V