8368 - [REGRESSION] [PP]Crash when selecting Open from Page source window

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[davidm]

6/15 Mac build

Load a browser window
Select Page Source Menu
Wait for source to load
While window is in the foreground, select open.
Crash.

There are also several other menu bugs ( quit and close are the enitites rather
than the text) multiple help menus ( I'll file a seperate bug about this)

Comment 1

[don]

Bill, check this out please ...

Comment 2

[Bill Law]

There are two problems here.  The crash is the result of this sequence of JS
calls:

toolkitCore->CloseWindow(window);
window.focus();

As a result of closing the window, some state data in the underlying nsWindow
gets deleted.  On the focus() call, this state data is required (referenced) but
is null.

I think this problem must be fixed because I suspect similar code in a web page:
  window.close();
  window.focus();
will crash the browser (which is not a good thing).  Unfortunately,
window.close() doesn't work (at least for xul dialogs) so I can't verify that
this crashes.  A new bug should be opened for this problem.

The second bug is the fact that we're closing the dialog.  This is due to some
funkiness related to sharing JS between the main browser window and the "view
source" window.  I fixed that code so now everything works.  BTW, I discovered
that opening a new page via File->Open results in that page's source appearing
in the "view source" window from which one opened the dialog.  I thought that
was a nice feature.

I have the fix and will check it in as soon as I can obtain the proper
authorizations.

Comment 3

[Bill Law]

I just checked in this fix:

Index: openLocation.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/src/openLocation.js,v
retrieving revision 1.4
diff -r1.4 openLocation.js
42a43
>         return;
Index: viewsource.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/src/viewsource.js,v
retrieving revision 1.3
diff -r1.3 viewsource.js
1,3d0
<   var coreName;
<
<
5,6c2,3
<     // Generate unique name.
<     coreName = "ViewSource." + ( new Date() ).getTime().toString();
---
>     // Generate unique name (var appCoreName declared in navigator.js).
>     appCoreName = "ViewSource." + ( new Date() ).getTime().toString();
10c7
<     appCore.Init( coreName );
---
>     appCore.Init( appCoreName );
19c16
<     XPAppCoresManager.Find( coreName ).loadUrl(url);
---
>     appCore.loadUrl(url);

Comment 4

[rubydoo123]

using 1999061808 on mac 8.6, app does not crash when selecting open from page
source window