Convert XMLStyleSheetProcessingInstruction to WebIDL

RESOLVED FIXED in mozilla21

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We didn't do this as part of bug 826703, so it's using the generic ProcessingInstruction binding, which means the sheet property is not available anymore.
So this is a potential web compat issue, to the extent that anyone uses .sheet on xml-stylesheet PIs, but not a problem past that, right?

My gut feeling is that we don't need to backport this...
(Assignee)

Comment 2

5 years ago
Created attachment 708778 [details] [diff] [review]
Rename nsXMLStylesheetPI to mozilla::dom::XMLStylesheetProcessingInstruction v1
Attachment #708778 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

5 years ago
Created attachment 708779 [details] [diff] [review]
v1
Attachment #708779 - Flags: review?(bzbarsky)
Comment on attachment 708778 [details] [diff] [review]
Rename nsXMLStylesheetPI to mozilla::dom::XMLStylesheetProcessingInstruction v1

r=me
Attachment #708778 - Flags: review?(bzbarsky) → review+
Comment on attachment 708779 [details] [diff] [review]
v1

> nsStyleLinkElement.h

The change to this file seems to be a stray.

>+++ b/dom/tests/mochitest/general/test_stylesheetPI.html

This needs some waitForExplicitFinish love, no?

>+++ b/dom/webidl/XMLStylesheetProcessingInstruction.webidl

We need a spec issue raised on this, right?

r=me with those fixed
Attachment #708779 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #5)
> This needs some waitForExplicitFinish love, no?

Wouldn't the insertion of the style-sheet PI block the page's onload that calls finish until the stylesheet has loaded? Or will the page onload sometime fire before the stylesheet's onload?
Oh, good point.  Yeah, that should be fine.
https://hg.mozilla.org/mozilla-central/rev/94dc3dd5174a
https://hg.mozilla.org/mozilla-central/rev/a2c01ef72e26
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.