836809 - Convert XMLStyleSheetProcessingInstruction to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

We didn't do this as part of bug 826703, so it's using the generic ProcessingInstruction binding, which means the sheet property is not available anymore.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So this is a potential web compat issue, to the extent that anyone uses .sheet on xml-stylesheet PIs, but not a problem past that, right?

My gut feeling is that we don't need to backport this...

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Rename nsXMLStylesheetPI to mozilla::dom::XMLStylesheetProcessingInstruction v1

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 708778 [details] [diff] [review]
Rename nsXMLStylesheetPI to mozilla::dom::XMLStylesheetProcessingInstruction v1

r=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 708779 [details] [diff] [review]
v1

> nsStyleLinkElement.h

The change to this file seems to be a stray.

>+++ b/dom/tests/mochitest/general/test_stylesheetPI.html

This needs some waitForExplicitFinish love, no?

>+++ b/dom/webidl/XMLStylesheetProcessingInstruction.webidl

We need a spec issue raised on this, right?

r=me with those fixed

Comment 6

[Peter Van der Beken [:peterv]]

(In reply to Boris Zbarsky (:bz) from comment #5)
> This needs some waitForExplicitFinish love, no?

Wouldn't the insertion of the style-sheet PI block the page's onload that calls finish until the stylesheet has loaded? Or will the page onload sometime fire before the stylesheet's onload?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, good point.  Yeah, that should be fine.

Comment 8

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94dc3dd5174a
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2c01ef72e26

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/94dc3dd5174a
https://hg.mozilla.org/mozilla-central/rev/a2c01ef72e26