Closed
Bug 836861
Opened 12 years ago
Closed 12 years ago
Mobile tests should work from release jobs.
Categories
(Release Engineering :: Release Automation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(1 file)
714 bytes,
patch
|
mozilla
:
review+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
I'm only making this a priority since tests like to infinitely retry now. We don't actually monitor these tests actively at this time.
The reason this patch is fine, is because we set the process name based on branch, then since release jobs have release-* at the head, we never match with: http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#5186
And then end up on the default name, which is org.mozilla.fennec rather than the proper name.
-- I tested this manually with a staging tegra up to (and including) installApp, and it installs fine as long as we give it the correct binary name as embedded in apk. (which this patch does)
Attachment #708708 -
Flags: review?(aki)
Comment 2•12 years ago
|
||
Comment on attachment 708708 [details] [diff] [review]
[configs] v1
Sure. Not any less hacky than the original.
I think the "real" fix could be to unzip the apk and look for the text file that blassey added that has the process name in it. (We held off using this before because it hadn't merged through all the trains, and then once it had it wasn't in the armv6 or xul or w/e other flavors. If it's there for noion and armv6 on all trains we could write a patch to do this.) That would fix Try, but we wouldn't detect merge day branding issues.
Attachment #708708 -
Flags: review?(aki) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/build/buildbot-configs/rev/9ecb70394c75
(In reply to Aki Sasaki [:aki] from comment #2)
> I think the "real" fix could be to unzip the apk and look for the text file
> that blassey added that has the process name in it.
O I would agree, and didn't even know of such a text file. Can you point out what bug that was and/or a bug on file on our end for using it?
(In fact I was just thinking of doing something like that if we could anyway)
Assignee | ||
Updated•12 years ago
|
Attachment #708708 -
Flags: checked-in+
Comment 4•12 years ago
|
||
bug 703080.
I don't think there's a bug on our end, but I've been wrong before.
Depends on: 703080
Assignee | ||
Comment 5•12 years ago
|
||
in production
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•