836887 - Zoom-In button using wrong icon on HiDPI screens

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Zoom-In Using Wrong Icon

Zoom-in button is using the New Window icon on Retina displays.

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Fix HiDPI Zoom-In Icon - 01

Comment 2

[Frank Yan (:fryn)]

Comment on attachment 708783 [details] [diff] [review]
Fix HiDPI Zoom-In Icon - 01

Review of attachment 708783 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Stephen Horlander from comment #0)
> Zoom-in button is using the New Window icon on Retina displays.

LOLMYBAD. Good catch :)

Comment 3

[Frank Yan (:fryn)]

The funny thing is that the New Window icon has a "plus" in it like the Zoom In icon, so it was correct in a way. :P

https://hg.mozilla.org/integration/mozilla-inbound/rev/803542803194

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Does this need to be uplifted to Aurora and Beta?

Comment 5

[Frank Yan (:fryn)]

(In reply to Jared Wein [:jaws] from comment #4)
> Does this need to be uplifted to Aurora and Beta?

Good point. It affects Firefox 18 and up.
I'm not exactly sure how the tracking-firefox* flags work, but I'll try to set the appropriate ones.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/803542803194

Comment 7

[Alex Keybl [:akeybl]]

Frank - please nominate for uplift no later than Monday to make it into FF19 (beta 5)

Comment 8

[Frank Yan (:fryn)]

Comment on attachment 708783 [details] [diff] [review]
Fix HiDPI Zoom-In Icon - 01

Review of attachment 708783 [details] [diff] [review]:
-----------------------------------------------------------------

The patch simply switches the "sprite" (the image region of a PNG) used for the Zoom In button in HiDPI mode.
This change only really affects users using Retina Display Macs who have customized their toolbars to contain a Zoom In button, so it's super low-risk.
Nevertheless, I think it's worth uplifting, because having the New Window icon in place of the Zoom In icon is a pretty bad glitch for those who do have that button.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 708783 [details] [diff] [review]
Fix HiDPI Zoom-In Icon - 01

Minor asset change, approving for Aurora/Beta.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4b95ccd3112b
https://hg.mozilla.org/releases/mozilla-beta/rev/57f8a1bc5bda

Comment 11

[juan becerra [:juanb]]

I was able to reproduce in 18, 19, 20 and 21. Initially I had not been able to reproduce with 19b4, so I had to try b3 where I was able to reproduce the problem. The latest versions of 19, 20, 21 show the correct icons.

Comment 12

[u279076]

Thanks Juan.