836890 - Assertion failure: "AncestorHasDirAuto set on node but not its children" with nested dir=auto

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: !aElement->AncestorHasDirAuto() || child->AncestorHasDirAuto() (AncestorHasDirAuto set on node but not its children), at content/base/src/DirectionalityUtils.cpp:672

Comment 1

[Alex Keybl [:akeybl]]

Simon - please nominate for tracking on Firefox 20 if this is a critical issue.

Comment 2

[Simon Montagu :smontagu]

Attachment: Patch

We add the AncestorHasDirAuto flag when adding a new element, but we need to add it to a new text-node also.

Comment 3

[Simon Montagu :smontagu]

Attachment: The testcase for checkin

Comment 4

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe0521304c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd0fca4f35d0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fe0521304c3
https://hg.mozilla.org/mozilla-central/rev/cd0fca4f35d0

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Can we get an aurora approval nomination here so this could get uplifted (if low risk) before we merge FF20 to Beta next Tuesday?

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 710095 [details]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 548206
User impact if declined: Text could appear in the wrong directionality in some dynamic situations with bidirectional text
Testing completed (on m-c, etc.): baked on m-c since 2013-02-06
Risk to taking this patch (and alternatives if risky): small risk of regressions in other dynamic situations with bidirectional text
String or UUID changes made by this patch: None

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 710095 [details]
Patch

Approving for uplift, we want this fix even with the small risk of regression on bidi text.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/beb2e598079c

FYI, I folded the test in with the patch.

Comment 11

[Tiziana Sellitto [:tiziana]]

Issue reproducible with the debug build from 2013-01-31. (assertion failure + Firefox crash)

Verified fixed with Firefox 21 latest debug build, on Mac OSX 10.8.3 (no assertion failure + no Firefox crash)
Build ID: 20130426142004