Closed Bug 836899 Opened 7 years ago Closed 7 years ago
Block Reflow State constructor's "a Metrics" parameter is unused
nsBlockReflowState's constructor takes a parameter "const nsHTMLReflowMetrics& aMetrics", but it never uses it. We should just drop that parameter.
It's been unused since the reflow branch landed, actually. :) It was used in: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.516 ...but not in: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.517 And that commit was the reflow branch.
Depends on: reflow-refactor
OS: Linux → All
Hardware: x86_64 → All
Attachment #708774 - Flags: review?(dbaron) → review+
I also removed a redundant assignment in that constructor, while I was in the neighborhood: mPresContext = aPresContext; That assignment is already done in the constructor's init list, a bit higher up. Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f306bf2d17d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.