836899 - nsBlockReflowState constructor's "aMetrics" parameter is unused

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Daniel Holbert [:dholbert]]

nsBlockReflowState's constructor takes a parameter "const nsHTMLReflowMetrics& aMetrics", but it never uses it.

We should just drop that parameter.

Comment 1

[Daniel Holbert [:dholbert]]

It's been unused since the reflow branch landed, actually. :)

It was used in:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.516
...but not in:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.517

And that commit was the reflow branch.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

I also removed a redundant assignment in that constructor, while I was in the neighborhood:
  mPresContext = aPresContext;

That assignment is already done in the constructor's init list, a bit higher up.

Pushed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/0f306bf2d17d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f306bf2d17d