Closed
Bug 837042
Opened 12 years ago
Closed 12 years ago
Remove gecko property from sendMessageToJava
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file, 1 obsolete file)
|
55.12 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
All messages sent via sendMessageToJava() have a gecko property for the data. We can remove this superfluous property to reduce code cruft and JSON processing.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #708947 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•12 years ago
|
||
This will break add-ons, but if we care about doing this, it would be easy enough to keep the old implementation around and change everything in the patch to use a different function (sendMessageToJava2 or something similar).
|
|
Assignee | |
Comment 3•12 years ago
|
||
This keeps support for the gecko property and logs a warning if it's used. Maybe we can remove this check altogether once add-ons have been updated?
Attachment #708947 -
Attachment is obsolete: true
Attachment #708947 -
Flags: review?(mark.finkle)
Attachment #709153 -
Flags: review?(mark.finkle)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 709153 [details] [diff] [review]
Remove gecko property from sendMessageToJava, v2
Let's get some Try server runs before landing
Attachment #709153 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Try run looks good: https://tbpl.mozilla.org/?tree=Try&rev=b0d88cf2d28a
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•