Closed Bug 837042 Opened 9 years ago Closed 9 years ago

Remove gecko property from sendMessageToJava

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file, 1 obsolete file)

All messages sent via sendMessageToJava() have a gecko property for the data. We can remove this superfluous property to reduce code cruft and JSON processing.
Attachment #708947 - Flags: review?(mark.finkle)
This will break add-ons, but if we care about doing this, it would be easy enough to keep the old implementation around and change everything in the patch to use a different function (sendMessageToJava2 or something similar).
This keeps support for the gecko property and logs a warning if it's used. Maybe we can remove this check altogether once add-ons have been updated?
Attachment #708947 - Attachment is obsolete: true
Attachment #708947 - Flags: review?(mark.finkle)
Attachment #709153 - Flags: review?(mark.finkle)
Comment on attachment 709153 [details] [diff] [review]
Remove gecko property from sendMessageToJava, v2

Let's get some Try server runs before landing
Attachment #709153 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/9077fe979def
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Depends on: 837848
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.